Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Redis password authentication #878

Merged
merged 1 commit into from
Oct 26, 2023
Merged

Fix Redis password authentication #878

merged 1 commit into from
Oct 26, 2023

Conversation

TomaSajt
Copy link
Contributor

I was packaging the app for Nixpkgs (merged now, btw) when I realised that the Redis password wasn't working correctly.

I looked up the docs of the Minion Redis Backend (https://metacpan.org/pod/Minion::Backend::Redis), and it turns out you need an x: before the password (or atleast that's how it worked for me).

Also, there was another place (the main plugin registering part) where the password wasn't even trying to be passed over to Minion. This was the main source of the errors it was throwing.

This PR addresses this by prepending a x: to the password, when given, and also providing a password at the other location.

@Difegue
Copy link
Owner

Difegue commented Oct 26, 2023

Looks about right - it's kinda embarrassing to have missed that considering I worked on the minion backend side as well 😅 goes to show how often I test with redis passwords

Thanks for the fix!

@Difegue Difegue merged commit 9277b62 into Difegue:dev Oct 26, 2023
1 check passed
@holopin-bot
Copy link

holopin-bot bot commented Oct 26, 2023

Congratulations @TomaSajt, you just earned a holobyte! Here it is: https://holopin.io/holobyte/clo6wu6q912390fmkgu27wlzl

This badge can only be claimed by you, so make sure that your GitHub account is linked to your Holopin account. You can manage those preferences here: https://holopin.io/account.
Or if you're new to Holopin, you can simply sign up with GitHub, which will do the trick!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants