Do not use chunked transfer encoding on ASP.NET Core 2.1 #1016
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Setting the Content-Length header explicitly will disable chunked transfer-encoding. However this was only done for one of the two WriteMessageAsync methods in SoapMessageEncoder. I have changed the other method to also set the Content-Length header. To do this I have used a MemoryStream. The other implementation used a StringWriter, which is not ideal, because it will convert to and from different encodings. We only want to find out the length of the stream, so a MemoryStream is faster and sufficient. Also changed the other WriteMessageAsync implementation to use a MemoryStream and removed the CustomStringWriter class. Fixes DigDes#1015
|
Thanks for merging! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setting the Content-Length header explicitly will disable chunked transfer-encoding. However this was only done for one of the two WriteMessageAsync methods in SoapMessageEncoder. I have changed the other method to also set the Content-Length header.
To do this I have used a MemoryStream. The other implementation used a StringWriter, which is not ideal, because it will convert to and from different encodings. We only want to find out the length of the stream, so a MemoryStream is faster and sufficient. Also changed the other WriteMessageAsync implementation to use a MemoryStream and removed the CustomStringWriter class.
Fixes #1015