Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not use chunked transfer encoding on ASP.NET Core 2.1 #1016

Merged
merged 1 commit into from
Feb 9, 2024
Merged

Do not use chunked transfer encoding on ASP.NET Core 2.1 #1016

merged 1 commit into from
Feb 9, 2024

Commits on Feb 9, 2024

  1. Do not use chunked transfer encoding on ASP.NET Core 2.1 

    Setting the Content-Length header explicitly will disable chunked
transfer-encoding. However this was only done for one of the two
WriteMessageAsync methods in SoapMessageEncoder. I have changed the
other method to also set the Content-Length header.

To do this I have used a MemoryStream. The other implementation used
a StringWriter, which is not ideal, because it will convert to and from
different encodings. We only want to find out the length of the stream,
so a MemoryStream is faster and sufficient. Also changed the other
WriteMessageAsync implementation to use a MemoryStream and removed the
CustomStringWriter class.

Fixes DigDes#1015
    @vidrenning
    vidrenning committed Feb 9, 2024
    Configuration menu
    Copy the full SHA
    ff90b2b View commit details
    Browse the repository at this point in the history