Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switchable Dark Mode #32

Closed
wants to merge 5 commits into from
Closed

Switchable Dark Mode #32

wants to merge 5 commits into from

Conversation

rdavydov
Copy link

@rdavydov rdavydov commented Feb 2, 2024

Checkbox on the central panel toggles dark mode: makes all the UI elements dark with the light text and applies the dark "Monokai" theme to all CodeMirror editors.

@rdavydov
Copy link
Author

rdavydov commented Feb 2, 2024

@rdavydov
Copy link
Author

rdavydov commented Feb 6, 2024

Also it saves this option to the local storage, so the dark mode state is remembered in the browser on the next visit.

@DinoChiesa
Copy link
Owner

DinoChiesa commented Feb 7, 2024 via email

@DinoChiesa
Copy link
Owner

THANK YOU for this cool PR.

Unfortunately I had made some changes in the tool afterwards, so I could not merge the PR as is. But I incorporated your changes in the latest. See this commit.

@DinoChiesa DinoChiesa closed this Apr 26, 2024
@rdavydov
Copy link
Author

@DinoChiesa

Hi Dino Chiesa,

I hope you're doing well.

I'm reaching out regarding this pull request I submitted on Feb 3 for the switchable dark mode feature. I noticed that the pull request was closed on Apr 26, and the feature was subsequently added to the tool without any mention of my contribution.

I understand that changes might have been made which led to conflicts, making it challenging to merge the pull request directly. However, I believe that acknowledging contributions is important in fostering a collaborative and respectful open-source community.

Would it be possible to credit my contribution to the switchable dark mode feature in the project? It could be as simple as mentioning my GitHub handle @rdavydov in the commit message or the project’s acknowledgments.

Thank you for considering this request. I appreciate your understanding and look forward to your response.

Best regards,
Roman Davydov
@rdavydov

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants