Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vista de organizaciones lista #5

Merged
merged 1 commit into from
Mar 23, 2015
Merged

vista de organizaciones lista #5

merged 1 commit into from
Mar 23, 2015

Conversation

lulirez
Copy link
Collaborator

@lulirez lulirez commented Mar 18, 2015

@Dinuuu nuevo pull

@Dinuuu
Copy link
Owner

Dinuuu commented Mar 19, 2015

fijate si podes squashear esos 2 commits para que sean uno solo. Asi despues no queda tan sucia la lista de commits

@lulirez
Copy link
Collaborator Author

lulirez commented Mar 19, 2015

@Dinuuu no se a que te referis con squashear... :(

@Dinuuu
Copy link
Owner

Dinuuu commented Mar 19, 2015

Podes hacerlo asi : https://ariejan.net/2011/07/05/git-squash-your-latests-commits-into-one/

Es para que no queden commits que no se sabe que hace y mantener 1 commit por feature

P.D: despues de hacer el squash tenes q pushear con -f si no me equivoco

@lulirez
Copy link
Collaborator Author

lulirez commented Mar 21, 2015

@Dinuuu listo el squash, se puede mergear...

@Dinuuu
Copy link
Owner

Dinuuu commented Mar 23, 2015

Rebasealo, pushealo, y si pasa Travis 👍

vista de organizaciones lista

fix
@@ -71,6 +71,7 @@ en:
done_edit_password: "Update"
done_edit_user: "Update"
organizations: "Organizations"
organization-link: "Go to organization"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

esto deberia ser
organization:
link: "Go to organization"

lulirez added a commit that referenced this pull request Mar 23, 2015
vista de organizaciones lista
@lulirez lulirez merged commit 2e6aeb0 into master Mar 23, 2015
@lulirez lulirez deleted the organizaciones branch April 19, 2015 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants