Skip to content

[pull] master from ropensci:master #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
Dec 26, 2020
Merged

Conversation

pull[bot]
Copy link

@pull pull bot commented Oct 21, 2020

See Commits and Changes for more details.


Created by pull[bot]

Can you help keep this open source service alive? 💖 Please sponsor : )

@pull pull bot assigned chschan Oct 21, 2020
@pull pull bot added the ⤵️ pull label Oct 21, 2020
@pull pull bot requested a review from chschan October 21, 2020 14:52
cpsievert and others added 9 commits October 22, 2020 10:32
* Replace iris examples with palmerpenguins

* Fix duplicate line

* Re-generate documentation

* Replaces iris with penguin in tests
* Fix bug. If is.null(data_xy): Set data_xy to mean of data_xy_min and data_xy_max.

* Add test. Check geom_errorbar is rendered when y aes is not set.

* Fix bug. geom_errobar is now rendered with flipped aes. Add test.

* Minor fixes. Add explanation and reprex for flipped_aes in geom2trace.GeomErrorbar. Simplify code in make_error.

* Update R/layers2traces.R

* Add visual test to check that geom_errobar is rendered when y aes is not set.

* Add visual test to check that geom_errobar is rendered with flipped aes.
* Fix #1870 by explicitly including milliseconds when converting to JSON

* Added visual test for #1870

* Fix POSIXt format for plotly JSON

According to plotly documentation (https://plotly.com/chart-studio-help/date-format-and-time-series/): "Chart Studio’s date format is 'yyyy-mm-dd HH:MM:SS.ssssss'.", so time_format in jsonlite::toJSON() changed to match.

* Fixing time format in test re: #1871

* Update test image for line-milliseconds.svg
* update to plotly.js v1.57.1

* move hexbin to suggests to avoid CRAN note

* validate new baselines
@pull pull bot added the merge-conflict Resolve conflicts manually label Dec 9, 2020
…cks on the figure data is overkill and is dependent on GEOS version
… available

Also, prefer jpeg over Cairo since it doesn't really matter what device we use, and it seems Cairo will need to be reinstalled in R 4.1 for it to work
…e docker container installs dependencies at run-time
chschan added a commit that referenced this pull request Dec 26, 2020
Merge branch 'ropensci-master'

# Conflicts:
#	R/plotly.R
#	inst/htmlwidgets/lib/plotlyjs/plotly-latest.min.js
@chschan chschan merged commit 94011cb into Displayr:master Dec 26, 2020
chschan added a commit that referenced this pull request Dec 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⤵️ pull merge-conflict Resolve conflicts manually
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants