BF-42: UCS4-range strings do not work properly when passed as arguments to JS-defined functions #10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This would also fix the ci tests |
… to JS functions `JS_NewUCStringCopyN` only copies by the specified length `u16Length`, so no need to make another `memcpy` call
Xmader
changed the title
Xmader
commented
Mar 31, 2023
| returnType.setBigInt(bigint); | ||
| } else if (_PyLong_NumBits(object) <= 53) { // num <= JS Number.MAX_SAFE_INTEGER, the mantissa of a float64 is 53 bits (with 52 explicitly stored and the highest bit always being 1) | ||
| uint64_t num = PyLong_AsLongLong(object); | ||
| int64_t num = PyLong_AsLongLong(object); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request resolves the following internal ticket: https://distributive.atlassian.net/browse/BF2-42