Skip to content

BF-51: js Date does not equal to py datetime in tests if the year number is less than 100 #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 12, 2023
Merged

BF-51: js Date does not equal to py datetime in tests if the year number is less than 100 #11

merged 1 commit into from
Apr 12, 2023

Conversation

Xmader
Copy link
Member

@Xmader Xmader commented Mar 30, 2023 •
edited
Loading

JS Date() constructor interprets year values from 0 to 99 as the years 1900 to 1999

This pull request resolves the following internal ticket:

@Xmader Xmader requested a review from zollqir March 30, 2023 00:06
@Xmader Xmader changed the title BF-51 BF-51: js Date does not equal to py datetime in tests if the year number is less than 100 Mar 30, 2023
@Xmader Xmader changed the base branch from main to BF-31 March 31, 2023 19:53
@Xmader Xmader changed the base branch from BF-31 to main March 31, 2023 20:14
@zollqir zollqir merged commit 7e2ed65 into main Apr 12, 2023
@Xmader Xmader deleted the BF-51 branch May 30, 2023 19:00
@philippedistributive philippedistributive mentioned this pull request Jan 25, 2024
Closed
@philippedistributive philippedistributive mentioned this pull request Feb 12, 2024
Closed
@philippedistributive philippedistributive mentioned this pull request May 7, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zollqir zollqir zollqir approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Xmader @zollqir