Skip to content

Conversation

Xmader
Copy link
Member

@Xmader Xmader commented Apr 26, 2023

Before the patch

def ident(x):
  print(x()) # 123.0
  return x
a = pm.eval("""(py_fn) => {
  const fn = py_fn(()=>{ return 123 })
  fn instanceof Function // true
  fn() // ??? TypeError: fn is not a function
  return fn
}""")(ident)
print(a()) #segfault

After patch


This pull request resolves the following internal ticket:

@Xmader Xmader self-assigned this Apr 26, 2023
@Xmader Xmader requested a review from zollqir April 26, 2023 22:43
@Xmader
Copy link
Member Author

Xmader commented May 30, 2023

GC subsystem overhaul won't land anytime soon before our first public release.

Copy link
Collaborator

@zollqir zollqir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants