BF-40: Py buffers (bytearray/memoryview/etc.) to JS TypedArray, JS TypedArray/ArrayBuffer to Py memoryview coercion
#20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ks` (offThreadPromiseState shutdown)
…been set when SpiderMonkey fails
(not implemented yet)
…ueToPyEventLoop` method
…ts to the callback, as spec-ed
…ument as the global object
…TypedArray, although we don't officially support numpy yet
Xmader
force-pushed
the
BF-40
branch
2 times, most recently
from
8a17dbc to
7fa4232
Compare
…emoryview coercion
…jsTypeFactory` may also raise exceptions
…verting a string constant to ‘char*’`
…emoryview coercion
…d on GC in `handleSharedPythonMonkeyMemory`
zollqir
approved these changes
Jun 16, 2023
There was a problem hiding this comment.
This all looks good. Only issues are those outlined in my comments for #16
regarding missing documentation for JobQueue, PromiseType, and PyEventLoop that share commits with this MR. The BufferType stuff is all excellent in this MR.
I am willing to merge this into main, and then have (#16) fix the documentation as outlined in my comments there.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bytearray/memoryview/etc.) coerce to JSTypedArray, respecting the element type codeTypedArraycoerces to Python memoryview, mappingTypedArraysubtypes (Uint8Array,Float64Array, ...) to type codesArrayBuffercoerces to simple memoryview with unsigned bytesThis pull request resolves the following internal ticket: