CI: build using the correct Python version #26
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Xmader
changed the title
Xmader
commented
May 29, 2023
| source $VENV # activate virtualenv | ||
| echo $VIRTUAL_ENV | ||
| echo $(poetry run python --version) | ||
| rm -rf ./build/ |
There was a problem hiding this comment.
Got the correct Python version with the cached ./build deleted.
It seems falling back to the cached values in build/CMakeCache.txt.
We shouldn't cache ./build dir anyhow.
There was a problem hiding this comment.
I guess it's because the virtualenv installed by poetry doesn't have the Development components as in find_package(Python 3.9...<3.12 COMPONENTS Interpreter Development REQUIRED)
There was a problem hiding this comment.
Ouhh that's a weird symptom.... Why did this not happen with my branch?
Xmader
force-pushed
the
Xmader/chore/build-with-correct-python-version
branch
from
265293c to
4ff7522
Compare
Xmader
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/Distributive-Network/PythonMonkey/actions/runs/5115473014/jobs/9196841495?pr=24#step:8:18 fails because cmake is not using the correct version of Python to build
pythonmonkey.so.