Skip to content

Xmader/fix/module system #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 22, 2023
Merged

Xmader/fix/module system #47

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ddbdb92
chore: `npm i` should be run in `python/pythonmonkey` directory
Xmader Jun 22, 2023
bcd6f67
test(promise): fix regex doesn't match when having `ctx-module`
Xmader Jun 22, 2023
3423f19
chore: must explicitly include `node_modules` into the wheel package
Xmader Jun 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions build_script.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,5 +11,6 @@ cd build
cmake ..
cmake --build . -j$CPUS

cd ../python/pythonmonkey
# npm is used to load JS components, see package.json
npm i
2 changes: 2 additions & 0 deletions pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,8 @@ include = [
"python/pythonmonkey/pythonmonkey.so",
"python/pythonmonkey/libmozjs*",

"python/pythonmonkey/node_modules/**/*",

# include all files for source distribution
{ path = "src", format = "sdist" },
{ path = "include", format = "sdist" },
Expand Down
2 changes: 1 addition & 1 deletion tests/python/test_pythonmonkey_eval.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -842,7 +842,7 @@ async def coro_fn(x):
# JS Promise to Python awaitable coercion
assert 100 == await pm.eval("new Promise((r)=>{ r(100) })")
assert 10010 == await pm.eval("Promise.resolve(10010)")
with pytest.raises(pm.SpiderMonkeyError, match="TypeError: .+ is not a constructor"):
with pytest.raises(pm.SpiderMonkeyError, match="^TypeError: (.|\\n)+ is not a constructor$"):
await pm.eval("Promise.resolve")(10086)
assert 10086 == await pm.eval("Promise.resolve.bind(Promise)")(10086)

Expand Down