BF-36 #9

Xmader · 2023-03-24T20:39:36Z

https://distributive.atlassian.net/jira/software/c/projects/BF2/issues/BF2-36

This pull request implements our custom pythonmonkey.bigint (extending the Python buitin int) type, and conversion for JS BigInt <-> Python pythonmonkey.bigint

…in one uint64_t

…igInt

…on 3.10

every int 0 literal would become a pm.bigint after the conversion

…nts > 2^53, or < -2^53

…igint, instead of throwing `PyLong_AsLongLong`'s "OverflowError: int too big to convert"

…table

Early return would cause a negative pm.bigint not resetting back to negative

zollqir

Looks good!

Xmader added 30 commits March 19, 2023 00:44

chore: remove unused explore module

5701b44

chore: add Testing/Temporary to .gitignore

b2717c8

feat(bigint): initial implementation of BigInt

b0dd745

refactor(bigint): use public SpiderMonkey API to read the sign bit

facb4aa

fix(bigint): properly get the digit storage if the number cannot fit …

2ed0c80

…in one uint64_t

feat(bigint): signed BigInt

3fcc3d0

perf(bigint): skip setting the sign bit if the number is positive

0f04c52

feat(bigint): handle boxed BigInt as in Object(1n)

1188540

test(bigint): write tests for BigInt

8eb93cc

test(bigint): write tests for boxed BigInt

0db2a4f

feat(bigint): check if integer exceeds Number.MAX_SAFE_INTEGER

e32f33c

refactor(pm.null): use designated initializers (C++20 feature)

f54a0d4

feat(bigint): create a custom class on PythonMonkey that maps to JS B…

421133e

…igInt

fix(pm.null): pythonmonkey.null shouldn't be instantiated

f3b2ee3

revert(pm.null): Py_TPFLAGS_DISALLOW_INSTANTIATION is new from Pyth…

3074fc4

…on 3.10

feat(bigint): convert Js BigInt to pm.bigint

bccfeff

fix(callJSFunc): fail-fast on exception

032bfa8

fix(bigint): long is 32-bit on Win64 or 32bit *nix

71cf248

fix(bigint): print out the IntType as a string

68e172f

feat(bigint): convert Python int/pm.bigint to JS BigInt

9954fc2

fix(bigint): use the JScontext from callJSFunc

924c622

Merge branch 'BF-31' into BF-36

e378867

fix(callJSFunc): fail-fast on exception

6c61320

fix(bigint): segfault (core dumped) when converting from hex string

08d02eb

fix(bigint): create a new object instead of reusing the object for int 0

72c9eb4

every int 0 literal would become a pm.bigint after the conversion

perf(bigint): use mozilla::Span constructor directly

fe7db7f

feat(bigint): convert negative pm.bigint to JS BigInt

cf1fe80

Merge branch 'BF-31' into BF-36

21702de

test(bigint): write tests for bigints as function arguments

185e363

fix(bigint): OverflowError instead of TypeError should be raised on i…

6604046

…nts > 2^53, or < -2^53

Xmader added 7 commits March 23, 2023 17:56

fix(bigint): ints larger than 64bits should also ask user to use pm.b…

b5069a1

…igint, instead of throwing `PyLong_AsLongLong`'s "OverflowError: int too big to convert"

test(bigint): write tests for adding bigints in JS function

e22979a

test(bigint): test with real-world example of calculating the factorial

1fc5167

test(bigint): test with real-world use case of calculating the crc32 …

e6453bf

…table

fix(bigint): include pm.bigint in jsTypeFactory TypeError message

53db0a1

feat(bigint): fast path for ints that can fit in one uint64

8e0e46e

fix(bigint): pm.bigint object malformed on NoMemory error

8a92587

Early return would cause a negative pm.bigint not resetting back to negative

Xmader requested a review from zollqir March 24, 2023 20:39

Xmader added the enhancement New feature or request label Mar 24, 2023

remove auto, add names to TODOs

8dcbcf5

zollqir approved these changes Mar 27, 2023

View reviewed changes

zollqir merged commit be0fdc7 into BF-31 Mar 27, 2023

Xmader deleted the BF-36 branch May 30, 2023 18:59

philippedistributive mentioned this pull request Jan 25, 2024

Memory leak: Proxies backing PyObject reference does not get decremented in finalize #220

Closed

philippedistributive mentioned this pull request Feb 12, 2024

segmentation fault after 60 seconds when trying to load socket.io #232

Closed

philippedistributive mentioned this pull request May 7, 2024

AddressSanitizer: heap-use-after-free in timerJobWrapper #341

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

BF-36 #9

BF-36 #9

Uh oh!

Xmader commented Mar 24, 2023

Uh oh!

zollqir left a comment

Uh oh!

Uh oh!

BF-36 #9

BF-36 #9

Uh oh!

Conversation

Xmader commented Mar 24, 2023

Uh oh!

zollqir left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!