Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Makes PasswordExposedChecker compatible with Windows #17

Merged
merged 2 commits into from
Oct 5, 2018
Merged

Makes PasswordExposedChecker compatible with Windows #17

merged 2 commits into from
Oct 5, 2018

Conversation

caugner
Copy link
Contributor

@caugner caugner commented Oct 5, 2018

The directory /tmp doesn't exist on Windows, so the CacheItemPool used by the PasswordExposedChecker cannot be written.

@coveralls
Copy link

coveralls commented Oct 5, 2018 •
edited
Loading

Pull Request Test Coverage Report for Build 104

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 89.362%
Totals Coverage Status
Change from base Build 99: 0.0%
Covered Lines: 42
Relevant Lines: 47
💛 - Coveralls

@DivineOmega
Copy link
Owner

This is great works, thanks! 😄

@DivineOmega DivineOmega merged commit 43b61d6 into DivineOmega:master Oct 5, 2018
@caugner caugner deleted the patch-1 branch October 5, 2018 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@caugner @coveralls @DivineOmega