New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test enhancement #29

Merged

DivineOmega merged 1 commit into DivineOmega:master from open-source-contributions:test_enhancement

Mar 21, 2020

Contributor

peter279k commented Mar 19, 2020

Changed log

The php-7.1.33 version is latest stable php-7.1 version now.
Remove trusty dist and these php-7.x versions are enabled on xenial dist by default.
Upgrade the PHPUnit version to be ^7.0||^8.0.
To be compatible with PHPUnit 7.x and PHPUnit 8.x versions, it should add :void to be compatible with PHPUnit\Framework\TestCase::setUp method.
Using the assertTrue and assertFalse assertions to assert expected value is true or false.


          Test enhancement

8bf5c55

coveralls commented Mar 19, 2020

Pull Request Test Coverage Report for Build 165

0 of 0 changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 86.735%

Totals
Change from base Build 163:	0.0%
Covered Lines:	85
Relevant Lines:	98

💛 - Coveralls

1 similar comment

coveralls commented Mar 19, 2020 •

edited

Loading

Pull Request Test Coverage Report for Build 165

0 of 0 changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 86.735%

Totals
Change from base Build 163:	0.0%
Covered Lines:	85
Relevant Lines:	98

💛 - Coveralls

Owner

DivineOmega commented Mar 21, 2020

Thank you!

DivineOmega merged commit 2973e43 into DivineOmega:master

peter279k deleted the test_enhancement branch

March 22, 2020 15:19

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet