Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support PHP 8 #30

Merged
merged 13 commits into from
Apr 20, 2021
Merged

Support PHP 8 #30

merged 13 commits into from
Apr 20, 2021

Conversation

jameswilddev
Copy link
Contributor

Adds support for PHP 8. The following changes were necessary to get the builds running again:

  • Composer 2 is installed by default, this isn't compatible with some of your dependencies so I've instructed it to roll back to Composer 1.
  • Psalm 1.1.9 includes syntax which isn't compatible with older PHP versions, while 1.1.8 isn't able to install on PHP 8. I've split the difference by making it install different versions depending upon the PHP version.
  • There was a use of a deprecated function which meant that the Psalm check was failing.
  • Also updates https://github.com/DivineOmega/psr-18-guzzle-adapter to allow 8.0 support.

@coveralls
Copy link

coveralls commented Apr 20, 2021

Pull Request Test Coverage Report for Build 172

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 86.735%

Totals Coverage Status
Change from base Build 166: 0.0%
Covered Lines: 85
Relevant Lines: 98

💛 - Coveralls

@jameswilddev jameswilddev marked this pull request as ready for review April 20, 2021 09:29
@DivineOmega DivineOmega merged commit 327f93e into DivineOmega:master Apr 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants