-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
French translation improvements from Crowdin made by: #1712
Conversation
magul
commented
Apr 17, 2021
- Arzugar (https://crowdin.com/profile/arzugar)
- Brice Copy (https://crowdin.com/profile/bcopy)
- Ewen (https://crowdin.com/profile/ewenquim)
- Joachim Jablon (https://crowdin.com/profile/ewjoachim)
- Raphael Das Gupta (https://crowdin.com/profile/das-g)
- Sylvain Chiron (https://crowdin.com/profile/frigory)
- Tom (https://crowdin.com/profile/firgon)
* Arzugar (https://crowdin.com/profile/arzugar) * Brice Copy (https://crowdin.com/profile/bcopy) * Ewen (https://crowdin.com/profile/ewenquim) * Joachim Jablon (https://crowdin.com/profile/ewjoachim) * Raphael Das Gupta (https://crowdin.com/profile/das-g) * Sylvain Chiron (https://crowdin.com/profile/frigory) * Tom (https://crowdin.com/profile/firgon)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Whoah that's a good update. I don't agree 100% with all the translations, but it's obviously much better after than before :)
Do we want second review here @das-g ? Or should we merge it? |
fr/django_start_project/README.md
Outdated
@@ -112,6 +112,28 @@ ALLOWED_HOSTS = ['127.0.0.1', '.pythonanywhere.com'] | |||
> **Note** : Si vous utilisez un Chromebook, ajoutez cette ligne à la fin de votre fichier settings.py : `MESSAGE_STORAGE = « django.contrib.messages.storage.session.SessionStorage »` | |||
> | |||
> Ajoutez `.amazonaws.com` à `ALLOWED_HOSTS` si vous utilisez cloud9 | |||
> | |||
> Si vous hébergez votre projet sur `Glitch.com`, nous devons protéger la clé secrète Django qui doit rester confidentielle (sinon, toute personne remixant votre projet pourrait la voir) : * Tout d'abord, nous allons créer une clé secrète aléatoire. Ouvrez à nouveau le terminal Glitch et tapez la commande suivante : {% filename %}Terminal{% endfilename %} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If I remember correctly, {% filename %}Terminal{% endfilename %}
needs to be on a line of its own for the rendering to look right. Let's update the translation now that #1714 has been merged.
(also for the {% filename %}
occurances below)
I think once #1712 (comment) is resolved, we can merge. Further improvements can always be made later. |
I've updated the French translation on Crowdin (using the translations from here, but now hopefully with proper markup). @magul Please update this PR accordingly. Thanks! |
* Raphael Das Gupta (https://crowdin.com/profile/das-g)
Done @das-g |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Markup looks good now. Regarding language, I'll have to trust the judgement of the native French speakers.