Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

French translation improvements from Crowdin made by: #1712

Merged
merged 2 commits into from
Apr 17, 2021

Conversation

@magul magul requested a review from a team April 17, 2021 11:07
Copy link
Member

@ewjoachim ewjoachim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoah that's a good update. I don't agree 100% with all the translations, but it's obviously much better after than before :)

@das-g das-g requested a review from a team April 17, 2021 11:34
@magul
Copy link
Member Author

magul commented Apr 17, 2021

Do we want second review here @das-g ? Or should we merge it?

@@ -112,6 +112,28 @@ ALLOWED_HOSTS = ['127.0.0.1', '.pythonanywhere.com']
> **Note** : Si vous utilisez un Chromebook, ajoutez cette ligne à la fin de votre fichier settings.py : `MESSAGE_STORAGE = « django.contrib.messages.storage.session.SessionStorage »`
>
> Ajoutez `.amazonaws.com` à `ALLOWED_HOSTS` si vous utilisez cloud9
>
> Si vous hébergez votre projet sur `Glitch.com`, nous devons protéger la clé secrète Django qui doit rester confidentielle (sinon, toute personne remixant votre projet pourrait la voir) : * Tout d'abord, nous allons créer une clé secrète aléatoire. Ouvrez à nouveau le terminal Glitch et tapez la commande suivante : {% filename %}Terminal{% endfilename %}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I remember correctly, {% filename %}Terminal{% endfilename %} needs to be on a line of its own for the rendering to look right. Let's update the translation now that #1714 has been merged.

(also for the {% filename %} occurances below)

@das-g
Copy link
Member

das-g commented Apr 17, 2021

Do we want second review here @das-g ? Or should we merge it?

I think once #1712 (comment) is resolved, we can merge. Further improvements can always be made later.

@das-g
Copy link
Member

das-g commented Apr 17, 2021

I've updated the French translation on Crowdin (using the translations from here, but now hopefully with proper markup).

@magul Please update this PR accordingly. Thanks!

@magul
Copy link
Member Author

magul commented Apr 17, 2021

Done @das-g

Copy link
Member

@das-g das-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Markup looks good now. Regarding language, I'll have to trust the judgement of the native French speakers.

@das-g das-g merged commit 2697945 into DjangoGirls:master Apr 17, 2021
@magul magul deleted the crowdin-translation-fr branch April 17, 2021 16:16
@magul magul restored the crowdin-translation-fr branch June 1, 2021 08:14
@magul magul deleted the crowdin-translation-fr branch June 1, 2021 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants