Skip to content
This repository has been archived by the owner on Jan 29, 2021. It is now read-only.

Fixing setup command. #1101

Merged
merged 1 commit into from
Aug 17, 2020
Merged

Fixing setup command. #1101

merged 1 commit into from
Aug 17, 2020

Conversation

weerd
Copy link
Contributor

@weerd weerd commented Aug 16, 2020

What's this PR do?

This pull request updates the SetupCommand() to fix an issue I ran into when running php artisan rogue:setup after a complete reset of my Homestead.

Console Error

Seems like the signature of the runCommand() has changed and now requires passing a class that implements the OutputInterface as the third argument.

I figured the simplest way to resolve this would be to use the call() command before hand and precede it with calling the line() command to write the message to the console.

How should this be reviewed?

👀

Any background context you want to provide?

It may be that we'll need to update the other projects that have their own Artisan setup command, since they likely also call the runCommand() as well.

Relevant tickets

🌵

Checklist

  • This PR has been added to the relevant Pivotal card.
  • Documentation added for new features/changed endpoints.
  • Added appropriate feature/unit tests.

@weerd weerd requested a review from a team as a code owner August 16, 2020 01:50
@weerd weerd requested review from lindsayrmaher and removed request for a team August 16, 2020 01:50
@lindsayrmaher
Copy link
Contributor

I updated my homestead and reset up Rogue last week and didn't run into this issue. but i also didn't use the php artisan rogue:setup command. But this seems like a reasonable update to make!

Copy link
Contributor

@lindsayrmaher lindsayrmaher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧼

@weerd
Copy link
Contributor Author

weerd commented Aug 17, 2020

I updated my homestead and reset up Rogue last week and didn't run into this issue. but i also didn't use the php artisan rogue:setup command. But this seems like a reasonable update to make!

Ah yeah, it defs requires running the setup command to run into this error. How did you set up Rogue without it? Just doing the steps it does manually?

@lindsayrmaher
Copy link
Contributor

How did you set up Rogue without it? Just doing the steps it does manually?

Yup yupp!

@weerd weerd merged commit 89a81c1 into master Aug 17, 2020
@weerd weerd deleted the fixing-console-setup-command branch August 17, 2020 15:56
@weerd weerd mentioned this pull request Aug 19, 2020
2 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants