Guard against viewportListeners being undefined
#52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test failing because to |
Sync master with develop
Update ember-cli None
|
@elidupuis If you rebase against |
|
@poteto Is there actually a way to change the target of a PR or do you just mean open a new one? |
|
Came across this and had a good chuckle 😂 isaacs/github#18 Opened a new PR to |
|
Closed by #60 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #45.
Note that I ran into the jQuery version conflict that appeared with the recent jQuery release. Pinning
jqueryinbower.jsonsolves this"jquery": "1.11.3". I didn't include this in the PR since it's unrelated.