Skip to content

add blank line after open tag as requested by psr12 #54

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 17, 2021
Merged

add blank line after open tag as requested by psr12 #54

merged 1 commit into from
Sep 17, 2021

Conversation

vsouz4
Copy link
Collaborator

@vsouz4 vsouz4 commented Sep 9, 2021

No description provided.

@vsouz4
Copy link
Collaborator Author

vsouz4 commented Sep 9, 2021

FYI I wanted to add @psr12 rule but that overly complicates things due to visibility_required rule, because of const visibility introduced only in 7.1 and default generator image is 7.4. We'd need multiple generator images per php version to make it work properly I suppose... not sure it's worth it...

@vsouz4 vsouz4 merged commit 9f33533 into master Sep 17, 2021
@vsouz4 vsouz4 deleted the psr12-blank-line-after-open-tag branch September 17, 2021 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JasonBenett JasonBenett JasonBenett approved these changes

@ivastly ivastly Awaiting requested review from ivastly

@mikemadisonweb mikemadisonweb Awaiting requested review from mikemadisonweb

@pelyib pelyib Awaiting requested review from pelyib

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@vsouz4 @JasonBenett