Skip to content

6 fix failing tests query variable integrality #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 28, 2025
Merged

6 fix failing tests query variable integrality #7

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c627797
check status on Highs_getColIntegrality (fail some tests)
rschwarz Mar 28, 2025
77e973a
work around unexpected Highs_getColIntegrality error
rschwarz Mar 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions mip/highs.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -678,6 +678,7 @@
def check(status):
if status == STATUS_ERROR:
raise mip.InterfacingError("Unknown error in call to HiGHS.")
return status


class SolverHighs(mip.Solver):
Expand Down Expand Up @@ -1431,12 +1432,15 @@ def var_set_obj(self: "SolverHighs", var: "mip.Var", value: numbers.Real):
check(self._lib.Highs_changeColCost(self._model, var.idx, value))

def var_get_var_type(self: "SolverHighs", var: "mip.Var") -> str:
# Highs_getColIntegrality only works if some variable is not continuous.
# Since we want this method to always work, we need to catch this case first.
if self._num_int_vars == 0:
return mip.CONTINUOUS

var_type = ffi.new("int*")
ret = self._lib.Highs_getColIntegrality(self._model, var.idx, var_type)
check(self._lib.Highs_getColIntegrality(self._model, var.idx, var_type))
if var_type[0] not in self._highs_type_map:
raise ValueError(
f"Invalid variable type returned by HiGHS: {var_type[0]} (ret={ret})"
)
raise ValueError(f"Invalid variable type returned by HiGHS: {var_type[0]}.")
return self._highs_type_map[var_type[0]]

def var_set_var_type(self: "SolverHighs", var: "mip.Var", value: str):
Expand Down