-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Upgrade to @ariakit/react v0.3.14 #778
Conversation
2e18cc3
to
745ede1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested all the updated components in storybook and they look good. I would suggest releasing this as a new major version for the reason you listed so that dependabot/renovate doesn't update this automatically.
If we run a parallel beta version instead, how long do you think we should keep it around for?
} | ||
|
||
/** | ||
* Merges React Refs into a single memoized function ref so you can pass it to an element. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is from https://github.com/ariakit/ariakit/blob/78b86daec880719625380492b711816457559efa/packages/ariakit-react-core/src/utils/hooks.ts#L126 right? Is there someway to attribute it back to them?
@gnapse my weekly bug requires the Ariakit upgrade here, should I take over this PR from you? |
745ede1
to
a47a974
Compare
1017fdf
to
5fd84df
Compare
@Bloomca I've noticed that you have work that depends on this. Let me know if you need help, as I should've been on top of this before, instead of neglecting it for some time. I can consider resuming the work here myself. |
6a13c4f
to
1fb91b9
Compare
1fb91b9
to
1255e04
Compare
1255e04
to
61fcab5
Compare
Sorry I made several releases due to another library depending on the Reactist, but I haven't realized it depends on |
7fcdfd9
to
3320f7b
Compare
Co-authored-by: Seva Zaikov <seva.zaikov@gmail.com>
Short description
Upgrades to the latest Ariakit. Ariakit underwent a relatively major API change, a breaking change. However, given how we encapsulate their API within ours, I suspect that it is not a breaking change for us (to be determined).
PR Checklist
npm run validate
and made sure no errors / warnings were shownCHANGELOG.md
package.json
andpackage-lock.json
(npm --no-git-tag-version version <major|minor|patch>
) refnpm run build-all
)Versioning
We're releasing this as a beta version, so that we can dip our toes into upgrading in the apps. The apps not only use Reactist, but in many cases use other Ariakit components directly. So when upgrading the apps to the new Reactist version, we need to also upgrade the apps to use the new Ariakit version directly.