Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Upgrade to @ariakit/react v0.3.14 #778

Merged
merged 12 commits into from
Feb 7, 2024
Merged

Conversation

gnapse
Copy link
Contributor

@gnapse gnapse commented May 31, 2023

Short description

Upgrades to the latest Ariakit. Ariakit underwent a relatively major API change, a breaking change. However, given how we encapsulate their API within ours, I suspect that it is not a breaking change for us (to be determined).

PR Checklist

  • Added tests for bugs / new features
  • Updated docs (storybooks, readme)
  • Executed npm run validate and made sure no errors / warnings were shown
  • Described changes in CHANGELOG.md
  • Bumped version in package.json and package-lock.json (npm --no-git-tag-version version <major|minor|patch>) ref
  • Updated all static build artifacts (npm run build-all)
  • Reviewed and approved Chromatic visual regression tests in CI

Versioning

We're releasing this as a beta version, so that we can dip our toes into upgrading in the apps. The apps not only use Reactist, but in many cases use other Ariakit components directly. So when upgrading the apps to the new Reactist version, we need to also upgrade the apps to use the new Ariakit version directly.

@gnapse gnapse requested a review from frankieyan May 31, 2023 18:37
@gnapse gnapse self-assigned this May 31, 2023
Copy link
Member

@frankieyan frankieyan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested all the updated components in storybook and they look good. I would suggest releasing this as a new major version for the reason you listed so that dependabot/renovate doesn't update this automatically.

If we run a parallel beta version instead, how long do you think we should keep it around for?

}

/**
* Merges React Refs into a single memoized function ref so you can pass it to an element.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

src/components/time/time.test.tsx Show resolved Hide resolved
src/tooltip/tooltip.tsx Show resolved Hide resolved
@frankieyan
Copy link
Member

frankieyan commented Jun 21, 2023

@gnapse my weekly bug requires the Ariakit upgrade here, should I take over this PR from you?

@gnapse
Copy link
Contributor Author

gnapse commented Oct 31, 2023

@Bloomca I've noticed that you have work that depends on this. Let me know if you need help, as I should've been on top of this before, instead of neglecting it for some time. I can consider resuming the work here myself.

@Bloomca Bloomca changed the title chore: Upgrade to @ariakit/react v0.2.3 chore: Upgrade to @ariakit/react v0.3.7 Dec 1, 2023
@Bloomca Bloomca changed the title chore: Upgrade to @ariakit/react v0.3.7 chore: Upgrade to @ariakit/react v0.3.14 Jan 17, 2024
@Bloomca
Copy link
Contributor

Bloomca commented Jan 18, 2024

Sorry I made several releases due to another library depending on the Reactist, but I haven't realized it depends on ^22.0.0, and not just any 22 version.

@gnapse gnapse changed the base branch from main to next February 7, 2024 19:46
@gnapse gnapse marked this pull request as ready for review February 7, 2024 19:54
@gnapse gnapse merged commit 0352954 into next Feb 7, 2024
5 checks passed
@gnapse gnapse deleted the ernesto/upgrade-ariakit branch February 7, 2024 19:55
nats12 pushed a commit that referenced this pull request May 31, 2024
Co-authored-by: Seva Zaikov <seva.zaikov@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants