fix(bold-and-italics): Disallow only whitespace in the markdown shortcuts #651
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rfgamaral
added
the
👀 Show PR
✅ Deploy Preview for doist-typist ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
rfgamaral
force-pushed
the
ricardo/better-bold-and-italics-regex
branch
from
f6b3a4c
to
b97ac40
Compare
rfgamaral
changed the title
rfgamaral
added a commit
that referenced
this pull request
Feb 8, 2024
doistbot
added a commit
that referenced
this pull request
Feb 8, 2024
## [4.0.2](v4.0.1...v4.0.2) (2024-02-08) ### Bug Fixes * **bold-and-italics:** Disallow only whitespace in the markdown shortcuts ([#651](#651)) ([4c740dd](4c740dd))
|
✅ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR disallows Markdown shortcuts (through typing or pasting) for the
BoldAndItalicsmark when the content between the delimiters is only whitespace. This brings the same RegExp as implemented in this Tiptap PR for all the built-in marks.PR Checklist
Test plan
Rich-text → Defaultstory***<text>***and___<text>___as before to have<text>both bold and italic***<whitespace>***or___<whitespace>___doesn't do anythingTip
When typing
***<space>(or___<space>), an horizontal break will appear in the editor. Just press Backspace once to undo that transformation, and then you are able to continue typing more whitespace or the ending delimiter***(or___).Demo