Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(github-webhooks): #186 implement github autodeployment with zero… #188

Merged
merged 8 commits into from
Jul 3, 2024

Conversation

Siumauricio
Copy link
Contributor

Implemente github auto deployment with zero configurations #186

@slowlydev
Copy link
Contributor

Thanks for the quick implementation. One thing I noticed thought that I think everyone can send a POST request to this endpoint and with the correct headers and body can trigger a deployment. Maybe we should use GitHub App Webhook Secrets

If you don't have time for this, I could try to implement this 😄

@Siumauricio
Copy link
Contributor Author

@slowlydev Good catch, if you can implement this would be awesome, Please!

@slowlydev
Copy link
Contributor

Okay I will start working on this when I get home :)

@slowlydev
Copy link
Contributor

Okay finally had time.
Implemented the verification as the GitHub docs recommend. Here's the PR from my fork into this branch. #189.
Maybe some adjustments at the docs would be nice too or a mention in the UI that GitHub now supports full Autodeploy. Also GitHub apps would need to be recreated and installed as we need the Webhook secret from the installation process. What do you think?

Add web hook verification to GitHub Autodeploy
@Siumauricio
Copy link
Contributor Author

@slowlydev Works like a charm, yeah in the release notes i will add a advice to recreate the github app, in the case they want to use autodeploy github deployments, also I will need to update the docs

Thank you!

@Siumauricio Siumauricio merged commit 21263a2 into canary Jul 3, 2024
2 checks passed
@Siumauricio Siumauricio deleted the feat/enable-autodeploy-github branch July 3, 2024 03:12
@Siumauricio Siumauricio mentioned this pull request Jul 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants