-
-
Notifications
You must be signed in to change notification settings - Fork 448
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(github-webhooks): #186 implement github autodeployment with zero… #188
Conversation
Thanks for the quick implementation. One thing I noticed thought that I think everyone can send a POST request to this endpoint and with the correct headers and body can trigger a deployment. Maybe we should use GitHub App Webhook Secrets If you don't have time for this, I could try to implement this 😄 |
@slowlydev Good catch, if you can implement this would be awesome, Please! |
Okay I will start working on this when I get home :) |
Okay finally had time. |
Add web hook verification to GitHub Autodeploy
@slowlydev Works like a charm, yeah in the release notes i will add a advice to recreate the github app, in the case they want to use autodeploy github deployments, also I will need to update the docs Thank you! |
Implemente github auto deployment with zero configurations #186