Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove hardcoded style from section #797

Closed
TDesjardins opened this issue Jul 19, 2023 · 0 comments
Closed

Remove hardcoded style from section #797

TDesjardins opened this issue Jul 19, 2023 · 0 comments
Assignees
@vegegoku
Labels
enhancement New feature or request version 1.x.x Version 1.x.x issues
Milestone
1.0.4

Comments

@TDesjardins
Copy link
Contributor

In section there is hardcoded style:
https://github.com/DominoKit/domino-ui/blob/master/domino-ui/src/main/java/org/dominokit/domino/ui/layout/Section.java#L41

which should be outsourced to css which is already available / (done):

domino-ui/domino-ui/src/main/resources/org/dominokit/domino/ui/public/css/domino-ui-style.css

Line 2648 in f5542d6

.right-sidebar {

So actually it can and should be removed from code.
@vegegoku vegegoku self-assigned this Oct 31, 2023
@vegegoku vegegoku added enhancement New feature or request version 1.x.x Version 1.x.x issues labels Oct 31, 2023
@vegegoku vegegoku added this to the 1.0.4 milestone Oct 31, 2023
vegegoku added a commit that referenced this issue Oct 31, 2023
@vegegoku
fix #797 Remove hardcoded style from section
2598bed
@vegegoku vegegoku closed this as completed Nov 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vegegoku vegegoku

Labels
enhancement New feature or request version 1.x.x Version 1.x.x issues
Projects
Domino UI
Status: Done
Milestone
1.0.4
Development

No branches or pull requests
2 participants
@TDesjardins @vegegoku