Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scroll loading does not work if the table is not displayed completely horizontally #862

Closed
JuliusRuppert opened this issue Oct 24, 2023 · 8 comments
Assignees
Labels
bug Something isn't working version 1.x.x Version 1.x.x issues version 2.x.x Version 2.x.x issues
Milestone

Comments

@JuliusRuppert
Copy link

Describe the bug
When having a table, that is not displayed completely horizontally, the scroll loading does not work as expected. When scrolling down to the last entry, new entries are displayed only sporadically. Problem appears on v1 and v2.

To Reproduce
Steps to reproduce the behavior:

  1. Go to Domino UI v1 Demo Scroll Loading or Domino UI v2 Demo Scroll Loading
  2. Reduce window width, so that the table is not displayed completely and a horizontally scroll bar is displayed.
  3. The Scoll Loading does only load new entries sporadic and not every time when we scroll to the very bottom of the table.

Expected behavior
The scoll loading should load new entrties even if the table is not completely displayed horizontally, which may be the default case when having many columns.

Desktop:

  • OS: Windows 10
  • Browser: Edge
  • Version: 118.0.2088.61
  • Browser: Firefox
  • Version: 118.0.2
@vegegoku vegegoku self-assigned this Oct 24, 2023
@vegegoku vegegoku added the bug Something isn't working label Oct 24, 2023
@vegegoku vegegoku added this to the 2.0.0-RC4 milestone Oct 24, 2023
@vegegoku vegegoku added version 1.x.x Version 1.x.x issues version 2.x.x Version 2.x.x issues labels Oct 24, 2023
vegegoku added a commit that referenced this issue Oct 26, 2023
vegegoku added a commit that referenced this issue Oct 26, 2023
@vegegoku vegegoku reopened this Oct 29, 2023
@JuliusRuppert
Copy link
Author

Hi @vegegoku,
thanks for fast fixing.
I implemented your changes in my code and tested it. In Firefox everything works fine. But with Edge and Chrome there is now the same problem when the table is displayed in full width. When it has horizontal scroll bars it works, but it does not work without.
Do you know why this happens?
Thanks

@vegegoku
Copy link
Member

vegegoku commented Nov 2, 2023

The issue is a little bit complicated it seems because the scroll bars. zoom and other factors affect the calculation for the scroll reaching the bottom, and it seems it has different behavior for different browsers. we have added an offset as part of the plugin config to make it configurable so the scrollbar does not need to reach the exact bottom , try playing with that while I investigate the issue again.

@vegegoku
Copy link
Member

vegegoku commented Nov 2, 2023

It is working on chrome, can you please prepare a reproducible project for this. I am not sure now what is causing the issue for you/
https://github.com/DominoKit/domino-ui/assets/5379625/3067013e-5254-48ba-a826-5a758ece5f74

@JuliusRuppert
Copy link
Author

Seems to depend on the display resolution. I previously tested on 3840x2160. When changing to 1920x1080 it works for me as well in Chrome.

@vegegoku
Copy link
Member

vegegoku commented Nov 2, 2023

@JuliusRuppert
Copy link
Author

My project to reproduce
JuliusRuppert/domino-ui-demo@f83a5ba

@vegegoku
Copy link
Member

vegegoku commented Nov 2, 2023

My project to reproduce JuliusRuppert/domino-ui-demo@f83a5ba

This does not seems to be right, that seems to be taken from an old commit, why not try the latest HEAD-SNAPSHOT instead

@JuliusRuppert
Copy link
Author

I have the same problems when compiling the development branch of the domino-ui-demo using SNAPSHOT-HEAD as it is in this commit DominoKit/domino-ui-demo@85a6c24.
This problem only appears in Chromium Browsers. I played a little around with the os display scale. When being on 100% everything works fine. But when I change it to a zoom, e.g. 125% it does not work any more. Maybe this is related to the problem you mentioned above in this #862 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working version 1.x.x Version 1.x.x issues version 2.x.x Version 2.x.x issues
Projects
Status: Done
Development

No branches or pull requests

2 participants