Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Git clone installation method in README points to wrong commit #16

Closed
rdbcasillas opened this issue Apr 3, 2019 · 1 comment
Closed

Comments

@rdbcasillas
Copy link

Hello,

Thank you for this exciting work.

I wanted to point out that the 'git clone' method in the README needs to be updated as it points to a wrong commit (from Gitlab).

➜  DAStk git branch -a -vv
* master                854722f [origin/master] Update README.md
  remotes/origin/HEAD   -> origin/master
  remotes/origin/master 854722f Update README.md

854722f only contains an update to README from previous branch from 10 months ago. So when I do git log:

commit 854722fea3baf98183d024bc882626d6735240ab
Author: igtr4848 <ignacio.tripodi@colorado.edu>
Date:   Fri Mar 15 00:02:35 2019 -0600

    Update README.md

commit 987997bd5c4b630b5b1ecc1d6cdadf22a1fa9456
Author: Ignacio Tripodi <ignaciot@gmail.com>
Date:   Sat Jun 23 15:35:30 2018 -0600

    Bugfix: Now generating barcode plots also works in Python 3

The difference between these two commits is only the README file, rest of the code is from June of last year when the python scripts were in their nascent phase. I went into this debugging route because I noticed that flags to the python script and the output were different from what's in the README.

All of this is a long winded way of saying that the README should be updated to

git clone https://github.com/Dowell-Lab/DAStk.git

instead of the biof-git.colorado.edu link

Thanks!

@rdbcasillas rdbcasillas changed the title Git clone installation method in README points to wrong branch Git clone installation method in README points to wrong commit Apr 3, 2019
@ignaciot
Copy link
Collaborator

ignaciot commented Apr 3, 2019

Thanks for pointing that out!! I just got the README fixed.

@ignaciot ignaciot closed this as completed Apr 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants