Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

control_barcode should be control_barcodes in barcode_plot.py #21

Closed
joshuamb opened this issue Jul 8, 2019 · 4 comments
Closed

control_barcode should be control_barcodes in barcode_plot.py #21

joshuamb opened this issue Jul 8, 2019 · 4 comments

Comments

@joshuamb
Copy link

joshuamb commented Jul 8, 2019

Lines 104 and 121 in barcode_plot.py are both
control_bc_data = np.array(control_barcode[relevant_tf].split(';'))
but control_barcode doesn't appear anywhere else in the code, and Python won't run the package because the variable is unknown. The variable control_barcodes is defined and I think that's the one that is supposed to be in those two lines. If I add an s to lines 104 and 121, the program runs okay.

@ignaciot
Copy link
Collaborator

ignaciot commented Jul 9, 2019

Thanks for the notice and solution! We'll push a fix for this ASAP.

@ignaciot
Copy link
Collaborator

ignaciot commented Jul 9, 2019

@magruca I pushed a fix to the barcode_fix branch, the issue was also present with the perturbation_barcodes variable for this new helper script. Could you guys test the different scenarios to ensure that's all? I'm about to lose connectivity but can merge and update the PyPi release later tonight.

magruca pushed a commit that referenced this issue Jul 10, 2019
Bugfix - Variable name typo as reported in #21
@magruca
Copy link
Collaborator

magruca commented Jul 10, 2019

Tested and good to go -- sorry this was my fault when I copied over the new file parsing code when we tweaked the md_scores.txt formatting. We can push the fix to PyPi

@magruca magruca closed this as completed Jul 10, 2019
@ignaciot
Copy link
Collaborator

Changes pushed to PyPi, now v0.3.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants