impl com.atproto.server.reserve_signing_key
#4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rewmcarthur-reserve-signing-key
…pds-drewmcarthur-reserve-signing-key
DrewMcArthur
commented
Jul 21, 2024
rsky-pds/src/repo/actor_store.rs
Outdated
Comment on lines
325
to
343
| pub async fn reserve_keypair(&self, did: Option<&str>) -> Result<String> { | ||
| if let Some(did) = did { | ||
| assert_safe_path_part(&did); | ||
| let key_loc = Path::new(&self.reserved_key_dir).join(did); | ||
| let key = load_key(key_loc); | ||
| if key.is_ok() { | ||
| return Ok(key?.did()?); | ||
| } | ||
| } | ||
| let keypair = Secp256k1Keypair::create(Some(Secp256k1KeypairOptions { | ||
| exportable: Some(true), | ||
| })) | ||
| .await?; | ||
| let key_did = keypair.did()?; | ||
| let key_loc = Path::new(&self.reserved_key_dir).join(&key_did); | ||
| fs::create_dir_all(self.reserved_key_dir.clone())?; | ||
| fs::write(key_loc, keypair.export()?)?; | ||
| Ok(key_did) | ||
| } |
There was a problem hiding this comment.
would appreciate a second set of eyes here - i want to make sure that i understand the conditional flow of this function. it seems to me like if we have a did that we pass in, then we'd want to load the key at that path and return the did of that key. otherwise, we go and create a new key, save it to a location, and return that new did.
if that's correct, this should probably be rewritten as a match did { Some(did) => {...}, None => {...} } expression. right now, there's the case where we do pass a did, but loading the file fails, and we create a new key instead (i.e. the if condition on line 330 is false, ! key.is_ok()).
but i'm just not too sure i have the logic right here.
…pds-drewmcarthur-reserve-signing-key
…pds-drewmcarthur-reserve-signing-key
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changes
mod actor_storefromrsky-pds/src/repo/mod.rsinto its ownrsky-pds/src/repo/actor_store.rsrsky-crypto/src/secp256k1/keypair.rs, implementsSecp256k1KeypairDidable,Signer,Keypair, andExportableKeypairtorsky_crypto::typesActorStoreConfig, pulling stuff fromenvActorStore::reserve_keypair(&self, did: Option<&str>) -> anyhow::Result<String>;cargo fmt, which updatedrsky-pds/src/repo/preference/mod.rstodo
actor_store::assert_safe_path_partActorStoreis initialized, match it with TS impl more?