Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[iOS] Localize bookmarks #1193

Merged
merged 2 commits into from
Sep 12, 2023
Merged

[iOS] Localize bookmarks #1193

merged 2 commits into from
Sep 12, 2023

Conversation

woxtu
Copy link
Contributor

@woxtu woxtu commented Sep 12, 2023

Issue

  • close N/A

Overview (Required)

  • This PR localizes Bookmarks

Links

Screenshot (Optional if screenshot test is present or unrelated to UI)

Before After

(Japanese)

(English)

Movie (Optional)

Before After

Copy link
Contributor

@tkhs0604 tkhs0604 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you as always! LGTM 🙌

@@ -48,6 +48,7 @@ struct BookmarkView<SessionView: View>: View {
)
}
}
.padding(.horizontal, 16)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@tkhs0604 tkhs0604 merged commit f5e04b0 into DroidKaigi:main Sep 12, 2023
4 checks passed
@woxtu woxtu deleted the localize-bookmarks branch September 14, 2023 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants