Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

On Linux: implement hot restart #70

Closed
fertrig opened this issue Jan 31, 2023 · 0 comments
Closed

On Linux: implement hot restart #70

fertrig opened this issue Jan 31, 2023 · 0 comments
Labels
help wanted Extra attention is needed linux Related to the Linux operating system

Comments

@fertrig
Copy link
Collaborator

fertrig commented Jan 31, 2023

Monarch lets users hot reload and hot restart stories on macOS and Windows. On Linux, users can hot reload, however hot restart is not implemented.

We are hoping to get help from the community on this issue.

The CLI dart code already handles the user request to hot restart. What's missing is the platform implementation to close the preview window and open a new one. Below are the implementations on macOS and Windows. The Linux implementation would be similar.

On Windows, see platform/windows/src/window_manager.cpp, function restartPreviewWindow():

void PreviewWindowManager::restartPreviewWindow()

On macOS, see platform/macos/monarch_macos/WindowManager.swift, function restartPreviewWindow():

func restartPreviewWindow() {

@fertrig fertrig added linux Related to the Linux operating system help wanted Extra attention is needed labels Jan 31, 2023
fertrig added a commit to fertrig/monarch that referenced this issue Feb 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed linux Related to the Linux operating system
Projects
None yet
Development

No branches or pull requests

1 participant