Skip to content

[Snyk] Upgrade node-fetch from 3.2.0 to 3.3.2 #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[Snyk] Upgrade node-fetch from 3.2.0 to 3.3.2 #3

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 8 additions & 7 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,6 @@
"dependencies": {
"@alch/alchemy-web3": "^1.1.12",
"axios": "^0.25.0",
"node-fetch": "^3.2.0"
"node-fetch": "^3.3.2"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

For application-level projects, it's a best practice to pin dependency versions instead of using ranges like ^. This ensures that every installation uses the exact same version of the dependency, leading to more stable and reproducible builds. Using a caret ^ allows for automatic minor version updates, which could potentially introduce unexpected breaking changes or bugs. Pinning the version gives you more control over when you upgrade dependencies.

Suggested change
"node-fetch": "^3.3.2"
"node-fetch": "3.3.2"

}
}