Dyn 5159 import export preferences #13301

jesusalvino · 2022-09-07T05:54:44Z

Purpose

Import and Export Settings Features
https://jira.autodesk.com/browse/DYN-5159

Declarations

Check these if you believe they are true

The codebase is in a better state after this PR
Is documented according to the standards
The level of testing this PR includes is appropriate
User facing strings, if any, are extracted into *.resx files
All tests pass using the self-service CI.
Snapshot of UI changes, if any.
Changes to the API follow Semantic Versioning and are documented in the API Changes document.
This PR modifies some build requirements and the readme is updated

Reviewers

@QilongTang

FYIs

@RobertGlobant20 @filipeotero

QilongTang · 2022-09-07T18:02:35Z

any gif of how it works now?

jesusalvino · 2022-09-07T20:53:24Z

any gif of how it works now?

Export

Import

src/DynamoCore/Configuration/PathManager.cs

src/DynamoCoreWpf/DynamoCoreWpf.csproj

src/DynamoCoreWpf/ViewModels/Menu/TrustedPathViewModel.cs

src/DynamoCore/Models/DynamoModel.cs

src/DynamoCoreWpf/ViewModels/Core/DynamoViewModel.cs

src/DynamoCoreWpf/ViewModels/Menu/PreferencesViewModel.cs

src/DynamoCoreWpf/Views/Menu/PreferencesView.xaml

src/DynamoCoreWpf/Views/Menu/PreferencesView.xaml.cs

QilongTang

Good progress, some questions and comments

RobertGlobant20

LGTM with two comments

src/DynamoCoreWpf/Views/Menu/PreferencesView.xaml.cs

src/DynamoCore/Configuration/PathManager.cs

src/DynamoCore/Configuration/PreferenceSettings.cs

src/DynamoCoreWpf/Views/Menu/PreferencesView.xaml.cs

src/DynamoCore/Models/DynamoModel.cs

src/DynamoCoreWpf/ViewModels/Core/DynamoViewModel.cs

src/DynamoCoreWpf/ViewModels/Menu/PreferencesViewModel.cs

src/DynamoCoreWpf/Views/Menu/PreferencesView.xaml.cs

QilongTang

some comments then LGTM with unit test

test/DynamoCoreTests/Configuration/PreferenceSettingsTests.cs

QilongTang

LGTM with one comment

QilongTang · 2022-09-21T00:19:31Z

Also the new test does not seem to pass from the CI: Dynamo.Tests.Configuration.PreferenceSettingsTests.TestImportCopySettings

QilongTang · 2022-09-21T18:50:37Z

src/DynamoCore/Configuration/PreferenceSettings.cs

+        public List<string> StaticFields()
+        {
+            return typeof(PreferenceSettings).GetMembers(BindingFlags.Static | BindingFlags.NonPublic).OfType<FieldInfo>().Select(field => field.Name).ToList();
+        }


Where is this used?

in the Unit Test, just updated.

QilongTang · 2022-09-21T19:14:51Z

LGTM waiting for PR checks to finish

* add nunit test adapter for 2022 (#13313) * add nunit test adapter for 2022 * update * Update Setup.cs * update * Update DynamoCore.csproj * Create System.Net.Http.dll * update * update Co-authored-by: pinzart <tiberiu.pinzariu@autodesk.com> * Filter Mouse Pressed Removed (#13319) - removed flashing white color on mouse pressed for the filter ui element * Fixing horizontal center (#13312) * Update Node AutoComplete Dialog Visuals (#13329) * Update Node AutoComplete Visuals * Reuse style from central location * Add editorconfig (#13233) * Dyn5272 (#13334) tests pass - merging this then will send cherry pick * Dyn 5159 import export preferences (#13301) * Import Export Settings * Info Icons * Indentation * Using Dynamo View Model reference * Moving the methods to the proper places according to their accessibility * Handling Generic Exceptions * updating the RaisePropertyChanged * Extracting the import extension file as a variable * Unique file name * Changing the access level * Various revisions * Cleaning vars * Adding Unit Test * Adding Comments and cleaning vars * Removing unnecessary methods * Refactoring to get the static fields automatically * Updating the Unit Test * checking new settings file * Adding validation info * Getting First Property with the same value * Updating valid TrustedLocations entries * move near clipping plane further away for more depth buffer precision. (#13338) passed here: merging. * Keep Node AutoComplete popup hidden when window deactivated (#13337) * Keep Node AutoComplete popup hidden when window deactivated * Add condition and null checks * comments Co-authored-by: pinzart90 <46732933+pinzart90@users.noreply.github.com> Co-authored-by: pinzart <tiberiu.pinzariu@autodesk.com> Co-authored-by: Deyan Nenov <dnenov@archilizer.com> Co-authored-by: jesusalvino <96534278+jesusalvino@users.noreply.github.com> Co-authored-by: Aaron (Qilong) <173288704@qq.com> Co-authored-by: Aabishkar KC <aabishkar@gmail.com>

…3343) * add nunit test adapter for 2022 (#13313) * add nunit test adapter for 2022 * update * Update Setup.cs * update * Update DynamoCore.csproj * Create System.Net.Http.dll * update * update Co-authored-by: pinzart <tiberiu.pinzariu@autodesk.com> * Filter Mouse Pressed Removed (#13319) - removed flashing white color on mouse pressed for the filter ui element * Fixing horizontal center (#13312) * Update Node AutoComplete Dialog Visuals (#13329) * Update Node AutoComplete Visuals * Reuse style from central location * Add editorconfig (#13233) * Dyn5272 (#13334) tests pass - merging this then will send cherry pick * Dyn 5159 import export preferences (#13301) * Import Export Settings * Info Icons * Indentation * Using Dynamo View Model reference * Moving the methods to the proper places according to their accessibility * Handling Generic Exceptions * updating the RaisePropertyChanged * Extracting the import extension file as a variable * Unique file name * Changing the access level * Various revisions * Cleaning vars * Adding Unit Test * Adding Comments and cleaning vars * Removing unnecessary methods * Refactoring to get the static fields automatically * Updating the Unit Test * checking new settings file * Adding validation info * Getting First Property with the same value * Updating valid TrustedLocations entries * move near clipping plane further away for more depth buffer precision. (#13338) passed here: merging. * add more failing tests * implement case 2 of replication * Update ReplicationTests.cs * add failing test * add some more failing tests * add some lacing tests that use arb rank params * fix tests 1. Missing replication Longest/Shortest attribute 2. Fix result - wrap in list (like old VM) Co-authored-by: pinzart90 <46732933+pinzart90@users.noreply.github.com> Co-authored-by: pinzart <tiberiu.pinzariu@autodesk.com> Co-authored-by: Deyan Nenov <dnenov@archilizer.com> Co-authored-by: jesusalvino <96534278+jesusalvino@users.noreply.github.com> Co-authored-by: Aaron (Qilong) <173288704@qq.com> Co-authored-by: Aabishkar KC <aabishkar@gmail.com> Co-authored-by: kirschm <michael.kirschner@autodesk.com>

* add nunit test adapter for 2022 (#13313) * add nunit test adapter for 2022 * update * Update Setup.cs * update * Update DynamoCore.csproj * Create System.Net.Http.dll * update * update Co-authored-by: pinzart <tiberiu.pinzariu@autodesk.com> * Filter Mouse Pressed Removed (#13319) - removed flashing white color on mouse pressed for the filter ui element * Fixing horizontal center (#13312) * Update Node AutoComplete Dialog Visuals (#13329) * Update Node AutoComplete Visuals * Reuse style from central location * Add editorconfig (#13233) * Dyn5272 (#13334) tests pass - merging this then will send cherry pick * Dyn 5159 import export preferences (#13301) * Import Export Settings * Info Icons * Indentation * Using Dynamo View Model reference * Moving the methods to the proper places according to their accessibility * Handling Generic Exceptions * updating the RaisePropertyChanged * Extracting the import extension file as a variable * Unique file name * Changing the access level * Various revisions * Cleaning vars * Adding Unit Test * Adding Comments and cleaning vars * Removing unnecessary methods * Refactoring to get the static fields automatically * Updating the Unit Test * checking new settings file * Adding validation info * Getting First Property with the same value * Updating valid TrustedLocations entries * move near clipping plane further away for more depth buffer precision. (#13338) passed here: merging. * add more failing tests * implement case 2 of replication * Update ReplicationTests.cs * add failing test * add some more failing tests * add replication test * fix merge conflict * fix merge conflict Co-authored-by: pinzart90 <46732933+pinzart90@users.noreply.github.com> Co-authored-by: pinzart <tiberiu.pinzariu@autodesk.com> Co-authored-by: Deyan Nenov <dnenov@archilizer.com> Co-authored-by: jesusalvino <96534278+jesusalvino@users.noreply.github.com> Co-authored-by: Aaron (Qilong) <173288704@qq.com> Co-authored-by: Aabishkar KC <aabishkar@gmail.com> Co-authored-by: Michael Kirschner <mjk.kirschner@gmail.com> Co-authored-by: kirschm <michael.kirschner@autodesk.com>

* add nunit test adapter for 2022 (#13313) * add nunit test adapter for 2022 * update * Update Setup.cs * update * Update DynamoCore.csproj * Create System.Net.Http.dll * update * update Co-authored-by: pinzart <tiberiu.pinzariu@autodesk.com> * Filter Mouse Pressed Removed (#13319) - removed flashing white color on mouse pressed for the filter ui element * Fixing horizontal center (#13312) * Update Node AutoComplete Dialog Visuals (#13329) * Update Node AutoComplete Visuals * Reuse style from central location * Add editorconfig (#13233) * Dyn5272 (#13334) tests pass - merging this then will send cherry pick * Dyn 5159 import export preferences (#13301) * Import Export Settings * Info Icons * Indentation * Using Dynamo View Model reference * Moving the methods to the proper places according to their accessibility * Handling Generic Exceptions * updating the RaisePropertyChanged * Extracting the import extension file as a variable * Unique file name * Changing the access level * Various revisions * Cleaning vars * Adding Unit Test * Adding Comments and cleaning vars * Removing unnecessary methods * Refactoring to get the static fields automatically * Updating the Unit Test * checking new settings file * Adding validation info * Getting First Property with the same value * Updating valid TrustedLocations entries * move near clipping plane further away for more depth buffer precision. (#13338) passed here: merging. * add more failing tests * implement case 2 of replication * Update ReplicationTests.cs * add failing test * add some more failing tests * add replication test * fix merge conflict * fix merge conflict * update replication test Co-authored-by: pinzart90 <46732933+pinzart90@users.noreply.github.com> Co-authored-by: pinzart <tiberiu.pinzariu@autodesk.com> Co-authored-by: Deyan Nenov <dnenov@archilizer.com> Co-authored-by: jesusalvino <96534278+jesusalvino@users.noreply.github.com> Co-authored-by: Aaron (Qilong) <173288704@qq.com> Co-authored-by: Aabishkar KC <aabishkar@gmail.com> Co-authored-by: Michael Kirschner <mjk.kirschner@gmail.com> Co-authored-by: kirschm <michael.kirschner@autodesk.com>

…namoDS#13343) * add nunit test adapter for 2022 (DynamoDS#13313) * add nunit test adapter for 2022 * update * Update Setup.cs * update * Update DynamoCore.csproj * Create System.Net.Http.dll * update * update Co-authored-by: pinzart <tiberiu.pinzariu@autodesk.com> * Filter Mouse Pressed Removed (DynamoDS#13319) - removed flashing white color on mouse pressed for the filter ui element * Fixing horizontal center (DynamoDS#13312) * Update Node AutoComplete Dialog Visuals (DynamoDS#13329) * Update Node AutoComplete Visuals * Reuse style from central location * Add editorconfig (DynamoDS#13233) * Dyn5272 (DynamoDS#13334) tests pass - merging this then will send cherry pick * Dyn 5159 import export preferences (DynamoDS#13301) * Import Export Settings * Info Icons * Indentation * Using Dynamo View Model reference * Moving the methods to the proper places according to their accessibility * Handling Generic Exceptions * updating the RaisePropertyChanged * Extracting the import extension file as a variable * Unique file name * Changing the access level * Various revisions * Cleaning vars * Adding Unit Test * Adding Comments and cleaning vars * Removing unnecessary methods * Refactoring to get the static fields automatically * Updating the Unit Test * checking new settings file * Adding validation info * Getting First Property with the same value * Updating valid TrustedLocations entries * move near clipping plane further away for more depth buffer precision. (DynamoDS#13338) passed here: merging. * add more failing tests * implement case 2 of replication * Update ReplicationTests.cs * add failing test * add some more failing tests * add some lacing tests that use arb rank params * fix tests 1. Missing replication Longest/Shortest attribute 2. Fix result - wrap in list (like old VM) Co-authored-by: pinzart90 <46732933+pinzart90@users.noreply.github.com> Co-authored-by: pinzart <tiberiu.pinzariu@autodesk.com> Co-authored-by: Deyan Nenov <dnenov@archilizer.com> Co-authored-by: jesusalvino <96534278+jesusalvino@users.noreply.github.com> Co-authored-by: Aaron (Qilong) <173288704@qq.com> Co-authored-by: Aabishkar KC <aabishkar@gmail.com> Co-authored-by: kirschm <michael.kirschner@autodesk.com>

* add nunit test adapter for 2022 (DynamoDS#13313) * add nunit test adapter for 2022 * update * Update Setup.cs * update * Update DynamoCore.csproj * Create System.Net.Http.dll * update * update Co-authored-by: pinzart <tiberiu.pinzariu@autodesk.com> * Filter Mouse Pressed Removed (DynamoDS#13319) - removed flashing white color on mouse pressed for the filter ui element * Fixing horizontal center (DynamoDS#13312) * Update Node AutoComplete Dialog Visuals (DynamoDS#13329) * Update Node AutoComplete Visuals * Reuse style from central location * Add editorconfig (DynamoDS#13233) * Dyn5272 (DynamoDS#13334) tests pass - merging this then will send cherry pick * Dyn 5159 import export preferences (DynamoDS#13301) * Import Export Settings * Info Icons * Indentation * Using Dynamo View Model reference * Moving the methods to the proper places according to their accessibility * Handling Generic Exceptions * updating the RaisePropertyChanged * Extracting the import extension file as a variable * Unique file name * Changing the access level * Various revisions * Cleaning vars * Adding Unit Test * Adding Comments and cleaning vars * Removing unnecessary methods * Refactoring to get the static fields automatically * Updating the Unit Test * checking new settings file * Adding validation info * Getting First Property with the same value * Updating valid TrustedLocations entries * move near clipping plane further away for more depth buffer precision. (DynamoDS#13338) passed here: merging. * add more failing tests * implement case 2 of replication * Update ReplicationTests.cs * add failing test * add some more failing tests * add replication test * fix merge conflict * fix merge conflict Co-authored-by: pinzart90 <46732933+pinzart90@users.noreply.github.com> Co-authored-by: pinzart <tiberiu.pinzariu@autodesk.com> Co-authored-by: Deyan Nenov <dnenov@archilizer.com> Co-authored-by: jesusalvino <96534278+jesusalvino@users.noreply.github.com> Co-authored-by: Aaron (Qilong) <173288704@qq.com> Co-authored-by: Aabishkar KC <aabishkar@gmail.com> Co-authored-by: Michael Kirschner <mjk.kirschner@gmail.com> Co-authored-by: kirschm <michael.kirschner@autodesk.com>

* add nunit test adapter for 2022 (DynamoDS#13313) * add nunit test adapter for 2022 * update * Update Setup.cs * update * Update DynamoCore.csproj * Create System.Net.Http.dll * update * update Co-authored-by: pinzart <tiberiu.pinzariu@autodesk.com> * Filter Mouse Pressed Removed (DynamoDS#13319) - removed flashing white color on mouse pressed for the filter ui element * Fixing horizontal center (DynamoDS#13312) * Update Node AutoComplete Dialog Visuals (DynamoDS#13329) * Update Node AutoComplete Visuals * Reuse style from central location * Add editorconfig (DynamoDS#13233) * Dyn5272 (DynamoDS#13334) tests pass - merging this then will send cherry pick * Dyn 5159 import export preferences (DynamoDS#13301) * Import Export Settings * Info Icons * Indentation * Using Dynamo View Model reference * Moving the methods to the proper places according to their accessibility * Handling Generic Exceptions * updating the RaisePropertyChanged * Extracting the import extension file as a variable * Unique file name * Changing the access level * Various revisions * Cleaning vars * Adding Unit Test * Adding Comments and cleaning vars * Removing unnecessary methods * Refactoring to get the static fields automatically * Updating the Unit Test * checking new settings file * Adding validation info * Getting First Property with the same value * Updating valid TrustedLocations entries * move near clipping plane further away for more depth buffer precision. (DynamoDS#13338) passed here: merging. * add more failing tests * implement case 2 of replication * Update ReplicationTests.cs * add failing test * add some more failing tests * add replication test * fix merge conflict * fix merge conflict * update replication test Co-authored-by: pinzart90 <46732933+pinzart90@users.noreply.github.com> Co-authored-by: pinzart <tiberiu.pinzariu@autodesk.com> Co-authored-by: Deyan Nenov <dnenov@archilizer.com> Co-authored-by: jesusalvino <96534278+jesusalvino@users.noreply.github.com> Co-authored-by: Aaron (Qilong) <173288704@qq.com> Co-authored-by: Aabishkar KC <aabishkar@gmail.com> Co-authored-by: Michael Kirschner <mjk.kirschner@gmail.com> Co-authored-by: kirschm <michael.kirschner@autodesk.com>

jesusalvino added 3 commits September 7, 2022 00:11

Import Export Settings

35b4648

Info Icons

799ae21

Indentation

6fe2d69

RobertGlobant20 requested review from zeusongit and reddyashish September 8, 2022 19:25

QilongTang added this to the 2.17.0 milestone Sep 8, 2022