Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

port annotation infrastructure to AArchXX #1672

Open
derekbruening opened this issue Apr 9, 2015 · 3 comments
Open

port annotation infrastructure to AArchXX #1672

derekbruening opened this issue Apr 9, 2015 · 3 comments

Comments

@derekbruening
Copy link
Contributor

Split from #1551

@derekbruening
Copy link
Contributor Author

We also need to port to AArch64 which we could include here as the implementations may be quite similar.

@derekbruening
Copy link
Contributor Author

There is further information here along with a potential contributor: https://groups.google.com/forum/#!topic/dynamorio-users/0HZGzngZmZ0

@fhahn fhahn self-assigned this Jul 17, 2018
derekbruening added a commit to DynamoRIO/drmemory that referenced this issue Mar 7, 2020
DR does not support annotations on ARM (DRi#1672) so we have to
disable our annotations for non-x86.

Adds ARM and Android builds to Travis.

Issue: DynamoRIO/dynamorio#4168, DynamoRIO/dynamorio#1672
Fixes DynamoRIO/dynamorio#4168
derekbruening added a commit to DynamoRIO/drmemory that referenced this issue Mar 7, 2020
DR does not support annotations on ARM (DRi#1672) so we have to
disable our annotations for non-x86.

Adds ARM and Android builds to Travis.

Issue: DynamoRIO/dynamorio#4168, DynamoRIO/dynamorio#1672
Fixes DynamoRIO/dynamorio#4168
derekbruening added a commit to DynamoRIO/drmemory that referenced this issue Mar 21, 2020
Fixes a broken install step for ARM by disabling the annotation header
install for non-x86.  DR does not yet support annotations on ARM
(DRi#1672).

Issue: DynamoRIO/dynamorio#4168, DynamoRIO/dynamorio#1672
derekbruening added a commit to DynamoRIO/drmemory that referenced this issue Mar 21, 2020
Fixes a broken install step for ARM by disabling the annotation header
install for non-x86.  DR does not yet support annotations on ARM
(DRi#1672).

Issue: DynamoRIO/dynamorio#4168, DynamoRIO/dynamorio#1672
@derekbruening
Copy link
Contributor Author

@byron-hawkins made a nice parameterizable multi-threaded test app for annotations client.annotation-concurrency and we ended up using it as a multi-threaded non-trivially-sized test app for many drcachesim tests.
However, it contains annotations, so the lack of annotation support on AArchXX now blocks running many drcachesim tests. Ideally we would just implement annotation support on AArchXX, but we could potentially hack the test to make the annotation macros resolve to empty code to make progress.

@derekbruening derekbruening changed the title port annotation infrastructure to ARM port annotation infrastructure to AArchXX Oct 5, 2020
derekbruening added a commit that referenced this issue Oct 6, 2020
Adds custom annotation macro defines to enable building the
client.annotation-concurrency executable and its shared library on
AArchXX.

Enables the 4 tests that require that executable, but do not need
annotation support: tool.drcachesim.threads,
tool.drcachesim.threads-with-config-file, tool.drcachesim.coherence,
and tool.drcachesim.TLB-threads.

Issue: #4474, #1672
derekbruening added a commit that referenced this issue Oct 6, 2020
Adds custom annotation macro defines to enable building the
client.annotation-concurrency executable and its shared library on
AArchXX.

Enables the 4 tests that require that executable, but do not need
annotation support: tool.drcachesim.threads,
tool.drcachesim.threads-with-config-file, tool.drcachesim.coherence,
and tool.drcachesim.TLB-threads.

Issue: #4474, #1672
@derekbruening derekbruening assigned derekbruening and unassigned fhahn Jan 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants