i#5036 AArch64: Remove Z register checks in tracer and sample clients #6431
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drcachesim's tracer.cpp, sample clients memtrace_simple.c and memval_simple.c have checks to avoid handling SVE scatter/gather memory instructions, i.e. use of Z registers in memory address operands. Now that a significant number of scatter/gather instructions have been implemented, these checks can be removed. Issues: #5036, #5365, #3044
jackgallagher-arm
approved these changes
Nov 9, 2023
brettcoon
pushed a commit
that referenced
this pull request
Nov 16, 2023
…#6431) drcachesim's tracer.cpp, sample clients memtrace_simple.c and memval_simple.c have checks to avoid handling SVE scatter/gather memory instructions, i.e. use of Z registers in memory address operands. Now that a significant number of scatter/gather instructions have been implemented, these checks can be removed. Issues: #5036, #5365, #3044
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
drcachesim's tracer.cpp, sample clients memtrace_simple.c and memval_simple.c have checks to avoid handling SVE scatter/gather memory instructions, i.e. use of Z registers in memory address operands. Now that a significant number of scatter/gather instructions have been implemented, these checks can be removed.
Issues: #5036, #5365, #3044