i#3544 RV64: Port sample 'cbr' to RISCV64 #6837
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. For RISCV64, conditional branch instruction of 'C' extension may not reach after adding clean call. So like X86, we add support to detect and convert compressed cbr to longer version. 2. For AARCH64 and RISCV64, a cbr may use the stolen reg and can not be mangled later as it is meta. So we check whether a cbr uses the stolen reg and replace it with a scratch reg. Now cbr works for AARCH64 and RISCV64. Still not work for ARM32 because of some bugs unrelated to cbr sample. Issue: DynamoRIO#1569, DynamoRIO#3544
ksco
reviewed
Jun 3, 2024
ksco
reviewed
Jun 3, 2024
chenhy0106
changed the title
chenhy0106
changed the title
chenhy0106
changed the title
chenhy0106
changed the title
ksco
approved these changes
Jun 17, 2024
|
(May not get to this for another day) |
derekbruening
approved these changes
Jun 19, 2024
|
LGTM, merging. |
|
Hi @derekbruening, @chenhy0106 is an intern in our lab, and he would like to submit more PRs to DynamoRIO on RV64 support. Can we have him in the committer team so he can merge PRs himself in the future? |
Done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now cbr works for RISCV64. Still does not work for ARM32/ARM64 because of some bugs unrelated to cbr sample.
Issue: #3544