Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix list_tables method to return names of all tables, not just first page #310

Merged
merged 2 commits into from
Oct 26, 2018
Merged

Fix list_tables method to return names of all tables, not just first page #310

merged 2 commits into from
Oct 26, 2018

Conversation

knovoselic
Copy link
Contributor

Old implementation returns only the first page of list_tables call. New implementation pages through the results to return all table names.

@andrykonchin andrykonchin merged commit 3b7c61e into Dynamoid:master Oct 26, 2018
@andrykonchin
Copy link
Member

Looks good 👍 . Thanks for the fix

pboling
pboling reviewed Oct 27, 2018
View reviewed changes
Copy link
Member

@pboling pboling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pboling pboling pboling left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@knovoselic @andrykonchin @pboling