Add smart count #314
Merged
Add smart count #314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrykonchin
force-pushed
the
add-smart-count
branch
from
5f63d40
to
504896b
Compare
andrykonchin
force-pushed
the
add-smart-count
branch
from
504896b
to
e3e3bb0
Compare
andrykonchin
force-pushed
the
add-smart-count
branch
from
e3e3bb0
to
4924a61
Compare
andrykonchin
force-pushed
the
add-smart-count
branch
from
4924a61
to
d9a8d9c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement
#countmethod forQuery/Scanchain in efficient way.Current implementation downloads all the documents in order to calculate
Query/Scanresult's size.Proposed implementation doesn't do it and uses
Select: "COUNT"options to return onlycountandscanned_countin response (API documentation).So now
Document.where('age.gt': 10).countworks much more efficiently.Related issues: #144 and #301