Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Travis CI. Fix specific bundler version installation #326

Merged
merged 1 commit into from
Jan 19, 2019

Conversation

andrykonchin
Copy link
Member

@andrykonchin andrykonchin commented Jan 11, 2019

Specify activemodel instead of rails in specs.

There is an issue with running specs against Rails 4.2 because this version requires bundler < 2.0.

Travis CI provides Ruby with preinstalled Bundler and makes it default gem (so you cannot uninstall it). After releasing Bundler 2 TravisCI preinstalls it and it breaks our specs.

As far as only Rails limits bundler version but not activemodel and Dynamoid depends on activemodel only lets get rid of Rails in specs

@andrykonchin andrykonchin changed the title Travis CI. Fix specific bundler version installation [WIP] Travis CI. Fix specific bundler version installation Jan 11, 2019
.travis.yml Outdated
# Rails 4.2 requires bundler < 2.0
- gem uninstall bundler
- gem install bundler -v '< 2'
- bundle --version
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool!

@andrykonchin andrykonchin changed the title [WIP] Travis CI. Fix specific bundler version installation Travis CI. Fix specific bundler version installation Jan 12, 2019
@pboling
Copy link
Member

pboling commented Jan 14, 2019

don't require the whole rails gem but only activemodel (because only rails gem limits bundler version) in specs

This would be a great step forward, as it would also allow people using activemodel outside Rails, like in a Sinatra app, to use Dynamoid. It may require some refactoring away from some rails-isms though. I think that's generally a positive move.

As a temporary fix I think skipping JRuby in the build is fine.

@andrykonchin
Copy link
Member Author

@pboling Actually Dynamoid already depends on activemodel only (https://github.com/Dynamoid/dynamoid/blob/master/dynamoid.gemspec#L43)

Rails is required only in test environment on CI so we could drop it right now.

@andrykonchin andrykonchin merged commit 91edd5d into master Jan 19, 2019
@andrykonchin andrykonchin deleted the fix-ci-build-and-bundler-issue branch January 19, 2019 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants