SC_Queryインスタンスの取得方法の修正 #191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
getSingletonInstanceメソッドを使用していない古い取得方法の記述が残っているのを修正。
nanasess
requested changes
Apr 26, 2018
| @@ -216,7 +216,7 @@ public function lfCheckError(&$objFormParam) | |||
| $objError->doFunc(array('発行日', 'year', 'month', 'day'), array('CHECK_DATE')); | |||
| $arrErr = array_merge($arrErr, $objError->arrErr); | |||
|
|
|||
| $objQuery = new SC_Query(); | |||
| $objQuery =& SC_Query_Ex::getSingletonInstance(); | |||
There was a problem hiding this comment.
その他の箇所が大半&付きだったので、それに倣っただけなんです。。。
不要であれば、全体で統一することも考えた方が良いですね。
nanasess
approved these changes
Apr 26, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
getSingletonInstanceメソッドを使用していない古い取得方法の記述が残っているのを修正。