Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SC_CheckError のテストケースを充実させる #264

Merged
merged 38 commits into from
May 21, 2019
Merged

SC_CheckError のテストケースを充実させる #264

merged 38 commits into from
May 21, 2019

Conversation

nanasess
Copy link
Contributor

@nanasess nanasess commented Apr 30, 2019 •
edited
Loading

リファクタリング

  • SC_CheckError_AbstractTestCase を作成
  • 共通処理を scenario メソッドにまとめる

テストの追加

  • doFunc
  • HTML_TAG_CHECK
  • EXIST_CHECK
  • EXIST_CHECK_REVERSE
  • SPTAB_CHECK
  • NO_SPTAB
  • ZERO_START
  • SELECT_CHECK
  • EQUAL_CHECK
  • DIFFERENT_CHECK
  • GREATER_CHECK
  • MAX_LENGTH_CHECK
  • MIN_LENGTH_CHECK
  • MAX_CHECK
  • MIN_CHECK
  • NUM_CHECK
  • NUM_POINT_CHECK
  • ALPHA_CHECK
  • TEL_CHECK
  • FULL_EXIST_CHECK
  • ALL_EXIST_CHECK
  • ONE_EXIST_CHECK
  • TOP_EXIST_CHECK
  • KANA_CHECK
  • KANABLANK_CHECK
  • ALNUM_CHECK
  • GRAPH_CHECK
  • ZERO_CHECK
  • NUM_RANGE_CHECK
  • NUM_COUNT_CHECK
  • EMAIL_CHECK
  • EMAIL_CHAR_CHECK
  • URL_CHECK
  • IP_CHECK
  • FILE_EXT_CHECK
  • FIND_FILE
  • FILE_EXIST_CHECK
  • FILE_SIZE_CHECK
  • FILE_NAME_CHECK
  • FILE_NAME_CHECK_BY_NOUPLOAD
  • CHECK_DATE
  • CHECK_DATE2
  • CHECK_DATE3
  • CHECK_BIRTHDAY
  • CHECK_SET_TERM
  • CHECK_SET_TERM2
  • CHECK_SET_TERM3
  • DIR_CHECK
  • DOMAIN_CHECK
  • MOBILE_EMAIL_CHECK
  • CHECK_REGIST_CUSTOMER_EMAIL
  • PROHIBITED_STR_CHECK
  • EVAL_CHECK
  • evalCheck
  • createParam
  • numelicCheck
  • PREF_CHECK

@coveralls
Copy link

coveralls commented May 1, 2019 •
edited
Loading

Coverage Status

Coverage increased (+5.9%) to 38.56% when pulling 9bfcf92 on nanasess:add-sccheckerrortest into aebcb97 on EC-CUBE:improve/php7.

@nanasess nanasess mentioned this pull request May 7, 2019
Merged
@kazumiiiiiiiiiii kazumiiiiiiiiiii added this to the 2.17.0 milestone May 14, 2019
@nanasess nanasess changed the title SC_CheckError のテストケースをリファクタリング SC_CheckError のテストケースを充実させる May 16, 2019
@chihiro-adachi chihiro-adachi merged commit 2b69746 into EC-CUBE:improve/php7 May 21, 2019
@chihiro-adachi
Copy link
Contributor

@nanasess ありがとうございます。マージしました。

@nanasess nanasess deleted the add-sccheckerrortest branch May 23, 2019 02:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nobuhiko nobuhiko nobuhiko approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
2.17.0
Development

Successfully merging this pull request may close these issues.
5 participants
@nanasess @coveralls @chihiro-adachi @nobuhiko @kazumiiiiiiiiiii