Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SC_Helper_DB のテストケース追加 #309

Merged
merged 33 commits into from
Sep 23, 2019

Conversation

nanasess
Copy link
Contributor

@nanasess nanasess commented Sep 6, 2019

  • 本体で未使用のメソッド、他で代替可能なメソッドに @deprecated 追加
  • 本体で static 参照しているメソッドに static 追加

- SC_Query::exists() で代用可能
- SC_Helper_DB::sfGetParentsArray() に置き換え
@coveralls
Copy link

Coverage Status

Coverage increased (+4.6%) to 47.768% when pulling b7a9d86 on nanasess:add-sc-helper-db-test into 7c98671 on EC-CUBE:improve/php7.

@chihiro-adachi chihiro-adachi added this to the 2.17.0 milestone Sep 17, 2019
@chihiro-adachi chihiro-adachi merged commit b3d4808 into EC-CUBE:improve/php7 Sep 23, 2019
@nanasess nanasess deleted the add-sc-helper-db-test branch October 3, 2022 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants