Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump version #323

Merged
merged 1 commit into from
Oct 23, 2019
Merged

Bump version #323

merged 1 commit into from
Oct 23, 2019

Conversation

nanasess
Copy link
Contributor

EC-CUBE2.17.0

@coveralls
Copy link

Coverage Status

Coverage remained the same at 51.622% when pulling fb14e12 on nanasess:bump-version into 4be7f30 on EC-CUBE:improve/php7.

@seasoftjapan
Copy link
Contributor

慣例的に、2.19.0 とか 2.20.0 じゃ無いんですか?

@nanasess
Copy link
Contributor Author

@seasoftjapan PHP7 なので 17 のままでいいんじゃないかという流れになりました

@kiy0taka kiy0taka changed the base branch from improve/php7 to master October 23, 2019 00:51
@kiy0taka kiy0taka merged commit 0c3d0da into EC-CUBE:master Oct 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nobuhiko nobuhiko nobuhiko approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@nanasess @coveralls @seasoftjapan @nobuhiko @kiy0taka