Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref #497 PHP8の修正 #499

Merged
merged 1 commit into from
Jan 12, 2022
Merged

ref #497 PHP8の修正 #499

merged 1 commit into from
Jan 12, 2022

Conversation

nobuhiko
Copy link
Contributor

@nobuhiko nobuhiko commented Dec 6, 2021

PHP8では Use of undefined constant が fatal errorになるため、PHP8系では data/config/config.php が存在しないと fatal error になってしまい、かつログファイルのパスも存在しないためにエラー画面も表示されない

@codecov-commenter
Copy link

Codecov Report

Merging #499 (3956305) into master (261ef5d) will decrease coverage by 0.09%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #499      +/-   ##
============================================
- Coverage     46.62%   46.52%   -0.10%     
  Complexity       14       14              
============================================
  Files            81       81              
  Lines         10580    10602      +22     
============================================
  Hits           4933     4933              
- Misses         5647     5669      +22     
Flag Coverage Δ
tests 46.52% <0.00%> (-0.10%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
data/class/SC_Initial.php 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 261ef5d...3956305. Read the comment docs.

@nanasess
Copy link
Contributor

nanasess commented Dec 7, 2021

PHPStan が落ちているのは #500 で修正しました

@chihiro-adachi chihiro-adachi added this to the 2.17.3 milestone Jan 12, 2022
@chihiro-adachi chihiro-adachi merged commit 87d0ffc into EC-CUBE:master Jan 12, 2022
@chihiro-adachi
Copy link
Contributor

@nobuhiko @nanasess
ありがとうございます、マージしました。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants