Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

カートページのペネトレーションテスト追加 #523

Merged
merged 6 commits into from
Mar 16, 2022

Conversation

nanasess
Copy link
Contributor

@nanasess nanasess commented Feb 16, 2022

  • カートページ(ログイン)のペネトレーションテストを追加
  • USE_FILENAME_DIR_INDEX = true にしないと、 OWASP ZAP のアクティブスキャンが page not found のエラーになるため、 USE_FILENAME_DIR_INDEX を環境変数で設定できるよう修正

@codecov-commenter
Copy link

codecov-commenter commented Feb 16, 2022

Codecov Report

Merging #523 (ee97713) into master (4b76107) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #523   +/-   ##
=======================================
  Coverage   54.40%   54.40%           
=======================================
  Files          76       76           
  Lines        9039     9039           
=======================================
  Hits         4918     4918           
  Misses       4121     4121           
Flag Coverage Δ
tests 54.40% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4b76107...ee97713. Read the comment docs.

USE_FILENAME_DIR_INDEX = true にしないと OWASP ZAP のアクティブスキャ
ンで page not found のエラーになってしまうため
@nanasess nanasess marked this pull request as ready for review February 17, 2022 09:26
@nanasess nanasess changed the title [WIP]カートページのペネトレーションテスト追加 カートページのペネトレーションテスト追加 Feb 18, 2022
@nanasess nanasess force-pushed the penetration-test-cart branch 2 times, most recently from ac765fc to 45173e7 Compare February 18, 2022 07:59
@nanasess
Copy link
Contributor Author

PHPStan のエラーは #522 で修正済み

@nanasess nanasess force-pushed the penetration-test-cart branch 3 times, most recently from 8ec672c to ee97713 Compare March 4, 2022 07:33
@kiy0taka kiy0taka merged commit 3d29506 into EC-CUBE:master Mar 16, 2022
@nanasess nanasess deleted the penetration-test-cart branch October 3, 2022 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants