Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub Actions のミドルウェアバージョン修正 #524

Merged
merged 1 commit into from
Mar 16, 2022

Conversation

nanasess
Copy link
Contributor

  • PHP8.1 を追加
  • PHPStan のエラー修正

    Return type mixed of method php_user_filter_lf2crlf::filter() is not covariant with tentative return type int of method php_user_filter::filter().

  • auto_detect_line_endings はPHP8.1.0以降非推奨

- PHP8.1 を追加
- PHPStan のエラー修正
  > Return type mixed of method php_user_filter_lf2crlf::filter() is not covariant with tentative return type int of method php_user_filter::filter().
- auto_detect_line_endings はPHP8.1.0以降非推奨
@codecov-commenter
Copy link

Codecov Report

Merging #524 (0add9ef) into master (4b76107) will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #524   +/-   ##
=======================================
  Coverage   54.40%   54.40%           
=======================================
  Files          76       76           
  Lines        9039     9039           
=======================================
  Hits         4918     4918           
  Misses       4121     4121           
Flag Coverage Δ
tests 54.40% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
data/class/SC_Initial.php 0.00% <0.00%> (ø)
data/class/helper/SC_Helper_CSV.php 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4b76107...0add9ef. Read the comment docs.

@nanasess
Copy link
Contributor Author

PHPStan のエラーは #522 で修正済み

@kiy0taka kiy0taka merged commit 79562fb into EC-CUBE:master Mar 16, 2022
@nanasess nanasess deleted the bump-php-version branch October 3, 2022 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants