Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ワークフローの再利用を使用して自動マージを実現する #861

Merged
merged 6 commits into from
Mar 22, 2024

Conversation

nanasess
Copy link
Contributor

@nanasess nanasess commented Mar 15, 2024

以下の流れで GitHub Actions を再構築する。
最初に docker image をビルドしておき、後続の job で docker image のキャッシュを活用してセットアップを高速化する。
ユニットテストや E2E テストは docker container 上で実行する
Allow auto merge を設定しておくことで、自動マージを実現する

  1. docker image のビルド&キャッシュ
  2. ユニットテスト、E2Eテスト、phpstan を並列で実行
  3. success job を実行(branch protection のステータスが成功となる)

image

@codecov-commenter
Copy link

codecov-commenter commented Mar 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.20%. Comparing base (302f86f) to head (a33e129).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #861   +/-   ##
=======================================
  Coverage   55.20%   55.20%           
=======================================
  Files          75       75           
  Lines        8912     8912           
=======================================
  Hits         4920     4920           
  Misses       3992     3992           
Flag Coverage Δ
tests 55.20% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nanasess nanasess force-pushed the feature-automerge branch 2 times, most recently from 7764177 to d914f2d Compare March 15, 2024 02:58
Composit action を使用して、各JOBで dockerbuild を実行する

- Pull Request で docker push できないため
- Pull Request で docker push できないため
@nanasess nanasess marked this pull request as ready for review March 15, 2024 06:40
@dotani1111
Copy link
Contributor

LGTM

@dotani1111 dotani1111 merged commit 8316d2e into EC-CUBE:master Mar 22, 2024
89 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants