-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ワークフローの再利用を使用して自動マージを実現する #861
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #861 +/- ##
=======================================
Coverage 55.20% 55.20%
=======================================
Files 75 75
Lines 8912 8912
=======================================
Hits 4920 4920
Misses 3992 3992
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
nanasess
force-pushed
the
feature-automerge
branch
2 times, most recently
from
March 15, 2024 02:58
7764177
to
d914f2d
Compare
Composit action を使用して、各JOBで dockerbuild を実行する - Pull Request で docker push できないため
- Pull Request で docker push できないため
nanasess
force-pushed
the
feature-automerge
branch
from
March 15, 2024 06:31
d914f2d
to
a33e129
Compare
nobuhiko
approved these changes
Mar 18, 2024
LGTM |
dotani1111
approved these changes
Mar 22, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
以下の流れで GitHub Actions を再構築する。
最初に docker image をビルドしておき、後続の job で docker image のキャッシュを活用してセットアップを高速化する。
ユニットテストや E2E テストは docker container 上で実行する
Allow auto merge を設定しておくことで、自動マージを実現する