Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dockerbuild workflow のみキャッシュを保存し、テスト実行時はキャッシュを保存しない #870

Merged
merged 1 commit into from
Mar 23, 2024

Conversation

nanasess
Copy link
Contributor

最初に実行される dockerbuild workflow のみ docker build のキャッシュを保存し、後続の workflow ではキャッシュの取得のみ行う。

若干の高速化と、以下のようなキャッシュのエラーを防止できる
https://github.com/EC-CUBE/ec-cube2/actions/runs/8384754767/job/22962608070#step:3:2232

- テスト実行時の docker build ではキャッシュを保存しない
@nanasess nanasess enabled auto-merge March 22, 2024 13:48
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.21%. Comparing base (33f507d) to head (defc1df).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #870   +/-   ##
=======================================
  Coverage   55.21%   55.21%           
=======================================
  Files          75       75           
  Lines        8913     8913           
=======================================
  Hits         4921     4921           
  Misses       3992     3992           
Flag Coverage Δ
tests 55.21% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nanasess nanasess merged commit bce476d into EC-CUBE:master Mar 23, 2024
88 checks passed
@nanasess nanasess deleted the fix-docker-build-cache branch March 23, 2024 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants