-
Notifications
You must be signed in to change notification settings - Fork 14
add parse hook that replaces build dependencies on Rust 1.65.0 by 1.75.0 on A64FX #86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
bot: build repo:eessi.io-2023.06-software instance:eessi-bot-mc-aws for:arch=x86_64/amd/zen2 |
New job on instance
|
New job on instance
|
bot: build repo:eessi.io-2023.06-software instance:eessi-bot-mc-aws for:arch=x86_64/amd/zen2 |
New job on instance
|
New job on instance
|
staging PR merged |
I don't understand, looks like it still doesn't include the changes from #82... |
The branch does include those changes, see https://github.com/bedroge/software-layer-scripts/blob/a64fx_rust_1.65.0/eb_hooks.py#L70. |
Let's do another rebuild bot: build repo:eessi.io-2023.06-software instance:eessi-bot-mc-aws for:arch=x86_64/amd/zen2 |
New job on instance
|
New job on instance
|
Extracted both tarballs on the bot account, and now it looks fine:
|
new staging PR merged |
Version 1.65.0 has build issues on A64FX. It's only used as a build dependency, and this PR adds a parse hook that replaces any build dependency on that particular version by version 1.75.0.
Tested by doing:
This fails, as expected, in the prepare step because of:
So it indeed replaced the build dependency, but we haven't installed that version yet.
Note that we would also need to add an empty module for the 1.65.0 version, and print an error message if someone wants to load that version.