Skip to content
This repository has been archived by the owner on Nov 6, 2023. It is now read-only.

Broken ruleset deletions #18949

Closed
wants to merge 13 commits into from
Closed

Broken ruleset deletions #18949

wants to merge 13 commits into from

Conversation

jayvdb
Copy link
Contributor

@jayvdb jayvdb commented Feb 18, 2020



<rule from="^http://(www\.)?partners\.peer1\.ca/"
to="https://$1partners.peer1.ca/" />
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note https://partners.peer1.com (.com vs .ca) does exist, however it redirects to https://www.cogecopeer1.com/en/partners/ which redirects to https://aptum.com/en/partners/ which is 404

But this rule never worked, so there is little reason to try rescuing it by creating a Peer1.com and/or cogecopeer1.com ruleset for previous operating names

jayvdb added 13 commits March 9, 2020 19:22
icmail.com is a parked domain, and has been for a while.
icmail.net and www.icmail.net have no A record.
myftp.utechsoft.com has an expired cert since 2017, and the https
page contains a meta redirect and note to use filecatalyst.com instead.

Closes EFForg#18940
Non-functional hosts.

Closes EFForg#18944
The rule applies to host research-store.com, which is non-operational
but the ruleset target is only researchstore.com, a parked domain.
instellaplatform.com no longer resolves.
Some affili.net sites redirect to awin.com, however most
timeout on https.
@jayvdb
Copy link
Contributor Author

jayvdb commented Mar 9, 2020

(Rebased to ensure it passes the new whitelist check; no changes occurred)

@J0WI
Copy link
Contributor

J0WI commented Mar 18, 2020

We tend to default_off rules with major issues first. If the target host does not exist anymore it's safe to remove them completely. Could you please split this PR? This allows us to review each case individually.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants